make static linking io_uring independent from static feature

Signed-off-by: June Strawberry <june@vern.cc>

Author: x86pup

Cargo.toml

@@ -36,6 +36,7 @@ io-uring = ["rust-librocksdb-sys/io-uring"]
 # and the "Coroutines / async MultiGet" section of the README for build
 # prerequisites. Linux only.
 coroutines = ["rust-librocksdb-sys/coroutines"]
+io-uring-static = ["rust-librocksdb-sys/io-uring-static"]
 numa = ["rust-librocksdb-sys/numa"]
 valgrind = []
 snappy = ["rust-librocksdb-sys/snappy"]

librocksdb-sys/Cargo.toml

@@ -38,6 +38,7 @@ bindgen-runtime = ["bindgen/runtime"]
 bindgen-static = ["bindgen/static"]
 mt_static = []
 io-uring = []
+io-uring-static = []
 # Build RocksDB with `USE_COROUTINES=1 USE_FOLLY=1` and link against a folly
 # install. Enables the multi-level parallel `MultiGet` async-IO path described
 # in the RocksDB blog post "Asynchronous IO in RocksDB". Linux only. Requires

librocksdb-sys/build.rs

@@ -752,24 +752,28 @@ mod vendor {
         #[cfg(feature = "io-uring")]
         {
             if _target.os == "linux" {
-                pkg_config::probe_library("liburing").unwrap_or_else(|e| {
-                    panic!(
-                        "the `io-uring` feature was requested but pkg-config probe for \
-                         `liburing` failed: {e}\n\
-                         Hints:\n\
-                          - Debian/Ubuntu:  apt-get install liburing-dev\n\
-                          - Fedora/RHEL:    dnf install liburing-devel\n\
-                          - Arch:           pacman -S liburing\n\
-                          - Alpine:         apk add liburing-dev\n\
-                          - or set PKG_CONFIG_PATH to a directory containing liburing.pc\n\
-                          - when cross-compiling, also set PKG_CONFIG_ALLOW_CROSS=1\n\
-                            and point PKG_CONFIG_PATH at the target sysroot's pkgconfig dir."
-                    )
-                });
+                // probe_library() only looks for shared objects, so it's
+                // misleading when statically linking liburing.
+                if cfg!(not(feature = "io-uring-static")) {
+                    pkg_config::probe_library("liburing").unwrap_or_else(|e| {
+                        panic!(
+                            "the `io-uring` feature was requested but pkg-config probe for \
+                             `liburing` failed: {e}\n\
+                             Hints:\n\
+                              - Debian/Ubuntu:  apt-get install liburing-dev\n\
+                              - Fedora/RHEL:    dnf install liburing-devel\n\
+                              - Arch:           pacman -S liburing\n\
+                              - Alpine:         apk add liburing-dev\n\
+                              - or set PKG_CONFIG_PATH to a directory containing liburing.pc\n\
+                              - when cross-compiling, also set PKG_CONFIG_ALLOW_CROSS=1\n\
+                                and point PKG_CONFIG_PATH at the target sysroot's pkgconfig dir."
+                        )
+                    });
+                }
                 _cfg.define("ROCKSDB_IOURING_PRESENT", Some("1"));
 
-                let mode = if cfg!(feature = "static") { "=static" } else { "" };
-                if cfg!(feature = "static") {
+                let mode = if cfg!(feature = "io-uring-static") { "=static" } else { "" };
+                if cfg!(feature = "io-uring-static") {
                     // centos uses its /usr/lib64 search path but liburing.a is installed
                     // by dnf oddly in /usr/lib unlike other installed archives.
                     println!("cargo:rustc-link-search=native=/usr/lib");