Skip to content

Static webhook setup with transformationFunction fails due to late quickjs initialisation #1228

@albanbruder

Description

@albanbruder

When using statically configured webhooks, a racecondition occurs when hookshot is started and the connection validator checks whether the quickjs engine has been loaded: https://github.com/matrix-org/matrix-hookshot/blob/main/src/generic/WebhookTransformer.ts#L45-L47

It seems that the engine is only initialized after the config has been loaded: https://github.com/matrix-org/matrix-hookshot/blob/main/src/App/BridgeApp.ts#L51-L53

Metadata

Metadata

Assignees

No one assigned

    Labels

    Generic HookInvolves the Generic Hook serviceS-MajorSeverely degrades major functionality or product features, with no satisfactory workaroundT-DefectBugs, crashes, hangs, vulnerabilities, or other reported problems.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions