Skip to content

Expose missing Jingle headers in umbrella header - #1308

Merged
pixlwave merged 3 commits into
matrix-org:developfrom
globekeeper:jingle-patch
Dec 10, 2021
Merged

Expose missing Jingle headers in umbrella header#1308
pixlwave merged 3 commits into
matrix-org:developfrom
globekeeper:jingle-patch

Conversation

@ferologics

@ferologics ferologics commented Nov 30, 2021

Copy link
Copy Markdown
Contributor

Expose missing Jingle headers in umbrella header

Signed-off-by: Frantisek Hetes f.hetes@gmail.com

@ferologics

Copy link
Copy Markdown
Contributor Author

Context: While adapting the Jingle extension that builds on top of MatrixSDK we needed to expose the missing headers
image

@pixlwave pixlwave left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @ferologics, looks good to me 👍

@pixlwave
pixlwave merged commit edbb0bb into matrix-org:develop Dec 10, 2021
@ferologics

Copy link
Copy Markdown
Contributor Author

@pixlwave thanks a bunch for merging! After further testing I've found an issue with missing symbols for MXCallKitAdapter due to the lack of #import "TargetConditionals.h". I opened a PR #1320 for that as well 🙂

@ferologics
ferologics deleted the jingle-patch branch December 10, 2021 13:17
@pixlwave pixlwave mentioned this pull request Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants