feat(ui,ffi): Add LatestEventValue::Local { sender, profile, .. }.#5885
Conversation
This patch adds a `profile: TimelineDetails<Profile>` field to `LatestEventValue::Local` in `matrix_sdk_ui::timeline` (and the corresponding `matrix_sdk_ffi` type).
Hywan
force-pushed
the
feat-sdk-latest-event-sender-profile
branch
from
0e8a455 to
c530757
Compare
poljar
left a comment
poljar
left a comment
There was a problem hiding this comment.
Looks good, there are some missing changelogs. Approving ahead of time.
| LatestEventValue::from_base_latest_event_value(base_value, &room, &client).await; | ||
|
|
||
| assert_matches!(value, LatestEventValue::Local { timestamp, content, is_sending } => { | ||
| assert_matches!(value, LatestEventValue::Local { timestamp, profile, content, is_sending } => { |
There was a problem hiding this comment.
Not sure how much effort it would be, but don't we want to have test with an available profile?
There was a problem hiding this comment.
The profile_from_user_id method is tested elsewhere, and it's not setup in these test cases. However, I've added the sender field too, and this one is tested, which increases the trust in the code (except if someone computes a different UserId in the meantime, but it's pretty unlikely).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5885 +/- ##
==========================================
- Coverage 88.62% 88.62% -0.01%
==========================================
Files 362 362
Lines 102666 102677 +11
Branches 102666 102677 +11
==========================================
+ Hits 90985 90994 +9
+ Misses 7449 7447 -2
- Partials 4232 4236 +4 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5885 will not alter performanceComparing Summary
|
Hywan
changed the title
LatestEventValue::Local { profile, .. }.LatestEventValue::Local { sender, profile, .. }.
This patch adds a `sender: OwnedUserId` field to `LatestEventValue::Local` in `matrix_sdk_ui::timeline` (and the corresponding `matrix_sdk_ffi` type).
Hywan
force-pushed
the
feat-sdk-latest-event-sender-profile
branch
from
768b9f9 to
aca8085
Compare
2 participants
This patch adds a
sender: OwnedUserIdand aprofile: TimelineDetails<Profile>fields toLatestEventValue::Localinmatrix_sdk_ui::timeline(and the correspondingmatrix_sdk_ffitype).