Skip to content

fix(oauth): use ruma::time::instant for wasm compatibility#5889

Merged
poljar merged 1 commit into
matrix-org:mainfrom
Johennes:johannes/ruma-instant
Nov 24, 2025
Merged

fix(oauth): use ruma::time::instant for wasm compatibility#5889
poljar merged 1 commit into
matrix-org:mainfrom
Johennes:johannes/ruma-instant

Conversation

@Johennes
Copy link
Copy Markdown
Contributor

@Johennes Johennes commented Nov 24, 2025

This switches from std::time::Instant to ruma::time::Instant because the former doesn't work under Wasm.

  • Public API changes documented in changelogs (optional)

Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
@Johennes Johennes force-pushed the johannes/ruma-instant branch from a97609e to 639eae8 Compare November 24, 2025 12:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.62%. Comparing base (2f7d2b3) to head (639eae8).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5889   +/-   ##
=======================================
  Coverage   88.61%   88.62%           
=======================================
  Files         362      362           
  Lines      102814   102814           
  Branches   102814   102814           
=======================================
+ Hits        91113    91116    +3     
+ Misses       7468     7464    -4     
- Partials     4233     4234    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Nov 24, 2025

CodSpeed Performance Report

Merging #5889 will not alter performance

Comparing Johennes:johannes/ruma-instant (639eae8) with main (2f7d2b3)

Summary

✅ 50 untouched

@Johennes Johennes marked this pull request as ready for review November 24, 2025 12:54
@Johennes Johennes requested a review from a team as a code owner November 24, 2025 12:54
@Johennes Johennes requested review from poljar and removed request for a team November 24, 2025 12:54
Copy link
Copy Markdown
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes sense.

@poljar poljar merged commit ae90708 into matrix-org:main Nov 24, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants