feat(sdk): Add support for the stable m.oauth UIAA type#5917
Conversation
By replacing the custom implementation with the one in Ruma. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
CodSpeed Performance ReportMerging #5917 will not alter performanceComparing Summary
|
| reqwest = { version = "0.12.24", default-features = false } | ||
| rmp-serde = "1.3.0" | ||
| ruma = { version = "0.14.0", features = [ | ||
| ruma = { git = "https://github.com/ruma/ruma", rev = "a67081e402dce14365089b34f50489dacc9c53b5", features = [ |
There was a problem hiding this comment.
We still didn't get the release out because of #5923. So this will need to wait for a bit.
There was a problem hiding this comment.
How long will it take? Because we could do a "patch" release of ruma if necessary.
There was a problem hiding this comment.
It should happen this week, I still need to write a small patch before we can release though.
There was a problem hiding this comment.
Okay, let's wait then.
|
AFAICT this worked fine when tested on Element X Android, although I'm not sure I tested the right thing. Is logging using OIDC enought? |
|
To test this code you need to reset the cross-signing keys. In the bindings it is exposed as |
|
Ok, I re-tested this by resetting the identity in one of my test accounts and it seemed to work fine. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5917 +/- ##
==========================================
- Coverage 88.65% 88.65% -0.01%
==========================================
Files 363 363
Lines 104691 104701 +10
Branches 104691 104701 +10
==========================================
+ Hits 92817 92818 +1
- Misses 7519 7526 +7
- Partials 4355 4357 +2 ☔ View full report in Codecov by Sentry. |
3 participants
By replacing the custom implementation with the one in Ruma.
It landed recently in the spec: matrix-org/matrix-spec#2234.