fix(ffi): remove undesired network request from the client builder#5919
Merged
Conversation
Making network requests before actually building a client interferes with offline support, especially so in lie-fi situations. The method is exposed through FFI though and can be used at the final user's discretion (e.g. when submitting a bug report).
CodSpeed Performance ReportMerging #5919 will not alter performanceComparing Summary
|
Hywan
approved these changes
Dec 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5919 +/- ##
=======================================
Coverage 88.65% 88.66%
=======================================
Files 363 363
Lines 104691 104691
Branches 104691 104691
=======================================
+ Hits 92817 92822 +5
+ Misses 7519 7514 -5
Partials 4355 4355 ☔ View full report in Codecov by Sentry. |
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
Dec 3, 2025
This patch disables the `matrix-sdk/federation-api` in `matrix-sdk-ffi` because it's no longer useful since the merge of matrix-org#5919.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making network requests before actually building a client interferes with offline support, especially so in lie-fi situations. The method is exposed through FFI though and can be used at the final user's discretion (e.g. when submitting a bug report).