Skip to content

refactor: Upgrade uniffi to the latest upstream#5929

Merged
jmartinesp merged 3 commits into
mainfrom
misc/upgrade-uniffi-to-latest
Dec 4, 2025
Merged

refactor: Upgrade uniffi to the latest upstream#5929
jmartinesp merged 3 commits into
mainfrom
misc/upgrade-uniffi-to-latest

Conversation

@jmartinesp
Copy link
Copy Markdown
Contributor

This is needed to fix an issue with the Kotlin bindings crashing the unit tests that reference any classes from the FFI bindings, even if they're instantiated with the NoHandle value to ensure it doesn't use the actual native code.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

@jmartinesp jmartinesp requested a review from a team as a code owner December 4, 2025 11:26
@jmartinesp jmartinesp requested review from Hywan and removed request for a team December 4, 2025 11:26
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (ae9600e) to head (564ad77).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5929   +/-   ##
=======================================
  Coverage   88.56%   88.56%           
=======================================
  Files         363      363           
  Lines      104838   104838           
  Branches   104838   104838           
=======================================
+ Hits        92853    92855    +2     
+ Misses       7628     7626    -2     
  Partials     4357     4357           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Dec 4, 2025

CodSpeed Performance Report

Merging #5929 will improve performances by 46.52%

Comparing misc/upgrade-uniffi-to-latest (564ad77) with main (ae9600e)

Summary

⚡ 1 improvement
✅ 49 untouched

Benchmarks breakdown

Benchmark BASE HEAD Change
Restore session [memory store] 400.6 ms 273.4 ms +46.52%

@jmartinesp
Copy link
Copy Markdown
Contributor Author

jmartinesp commented Dec 4, 2025

Merging #5929 will improve performances by 46.62%

image

@poljar
Copy link
Copy Markdown
Contributor

poljar commented Dec 4, 2025

Merging #5929 will improve performances by 46.62%

image

Sometimes it behaves like this, on one of the simplests benchmarks we have. One of these days we need to investigate.

@jmartinesp
Copy link
Copy Markdown
Contributor Author

I knew it was too good to be true! (also, there are no bindings involved in the benchmark so... 😅 )

Copy link
Copy Markdown
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jmartinesp jmartinesp merged commit bfd8cfa into main Dec 4, 2025
54 checks passed
@jmartinesp jmartinesp deleted the misc/upgrade-uniffi-to-latest branch December 4, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants