feat(room): make load_event_with_relations also load relations when falling back to the network#5930
Merged
andybalaam merged 4 commits intoDec 8, 2025
Conversation
97559da to
6704df8
Compare
Johennes
commented
Dec 4, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5930 +/- ##
=======================================
Coverage 88.50% 88.50%
=======================================
Files 362 362
Lines 103291 103351 +60
Branches 103291 103351 +60
=======================================
+ Hits 91413 91471 +58
+ Misses 7535 7533 -2
- Partials 4343 4347 +4 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5930 will not alter performanceComparing Summary
|
andybalaam
approved these changes
Dec 5, 2025
Member
andybalaam
left a comment
There was a problem hiding this comment.
Good catch. Looks good to me but I'm going to ask someone from the Rust team to have a quick check, especially on your question about limiting the number to fetch.
6704df8 to
64aee66
Compare
…alling back to the network Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
64aee66 to
956c6d7
Compare
andybalaam
reviewed
Dec 5, 2025
andybalaam
requested changes
Dec 5, 2025
Member
andybalaam
left a comment
There was a problem hiding this comment.
A couple of questions to resolve.
andybalaam
reviewed
Dec 5, 2025
… when falling back to the network Change limit to 256 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
… when falling back to the network Cache related events after loading them Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
… when falling back to the network Try loading relations from the cache before falling back to the server Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Room::load_event_with_relationscurrently tries to load the event and any known relations from the cache first. If that fails,/eventis called to retrieve the event itself. Nothing is done to also load the relations, however.This PR extends
load_event_with_relationsto also issue/relationsrequests to load any relations when the cache look-up failed.