fix(sdk): Better handling of redacted and redaction events in Latest Event#5932
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5932 +/- ##
==========================================
- Coverage 88.50% 88.49% -0.01%
==========================================
Files 362 362
Lines 103438 103423 -15
Branches 103438 103423 -15
==========================================
- Hits 91549 91529 -20
- Misses 7539 7544 +5
Partials 4350 4350 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5932 will not alter performanceComparing Summary
|
36c5c25 to
76a4724
Compare
…Event. This patch revisits the way redacted and redaction events are handled in the Latest Event. Previously, all redacted events were considered suitable candidate. It's no longer the case. Redaction and redacted events are no longer considered suitable. This patch also revisits `rfind_map_event_in_memory_by` to return a `&TimelineEvent` instead of an `OwnedEventId`, which could be more performant in the future. The tests have been updated accordingly.
Signed-off-by: Stefan Ceriu <stefanc@matrix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch revisits the way redacted and redaction events are handled in the Latest Event.
Previously, all redacted events were considered suitable candidate. It's no longer the case.
Redaction and redacted events are no longer considered suitable.
This patch also revisits
rfind_map_event_in_memory_byto return a&TimelineEventinstead of anOwnedEventId, which could be more performant in the future.The tests have been updated accordingly.