change(notification_client): use cross process locking event and media stores instead of in-memory ones#5934
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5934 +/- ##
=======================================
Coverage 88.93% 88.94%
=======================================
Files 357 357
Lines 99195 99219 +24
Branches 99195 99219 +24
=======================================
+ Hits 88224 88247 +23
- Misses 6987 6990 +3
+ Partials 3984 3982 -2 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
e377d58 to
a836b72
Compare
| event_cache_store: self.event_cache_store.clone(), | ||
| media_store: self.media_store.clone(), |
There was a problem hiding this comment.
You're cloning the EventCacheStoreLock and MediaStoreLock, with the main cross-process holder name. It doesn't use the new cross_process_store_locks_holder_name received by argument here.
77931b6 to
116003a
Compare
…a stores instead of in-memory ones This will allow the NSE process to populate the event cache store with even data after retrieving it from sync, as opposed to dropping after rendering the notification it as it did previously.
This patch renames `clone_with_in_memory_state_store` to `derive_states_for_notification_client`. At least it clarifies what it does.
d0571f6 to
e98e4f5
Compare
|
@stefanceriu if you want to give another try, have fun! |
|
Turns out this doesn't actually work and we probably do need the state store cross process lock. Will raise again once we're ready to do this properly. |
This will allow the NSE process to populate the event cache store with even data after retrieving it from sync, as opposed to dropping after rendering the notification it as it did previously.