fix(event_cache): store correct encryption information for local echoes#5936
Conversation
poljar
left a comment
There was a problem hiding this comment.
We can tweak this a bit more to make it more correct, also a regression test for this would be very welcome.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5936 +/- ##
==========================================
- Coverage 88.50% 88.50% -0.01%
==========================================
Files 362 362
Lines 103351 103399 +48
Branches 103351 103399 +48
==========================================
+ Hits 91469 91511 +42
- Misses 7534 7540 +6
Partials 4348 4348 ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #5936 will not alter performanceComparing Summary
|
3e173fb to
56d370b
Compare
… Olm machine's raw encryption methods
…ng `MessageLike` and `RawMessageLike` events
…` to create a `DecryptedRoomEvent` and corresponding `TimelineEvent` and correctly populate the Event Cache.
…ndMessageLikeEvent` results
56d370b to
34f8f1c
Compare
|
Okay, I went ahead and rewrote most of this based on the last idea. |
poljar
left a comment
There was a problem hiding this comment.
Alright, this looks good. Very nicely done.
Can we just get appropriate changelog entries for the main crate and the crypto crate.
Furthermore, a regression test for this would be very nice.
poljar
left a comment
There was a problem hiding this comment.
Took a bit of time to figure out why things weren't working, but we got there.
and adapt encrypt_room_event to preserve its interface despite the change introduced in matrix-org/matrix-rust-sdk#5936 .
and adapt encrypt_room_event to preserve its interface despite the change introduced in matrix-org/matrix-rust-sdk#5936 .
This patch exposes one's underlying
EncryptionInfoused when sending rawRoomevents, uses it to create aDecryptedRoomEventand correspondingTimelineEvent, and correctly populates the EventCache with local echoes.