Skip to content

Spaces: Add a method to reset a SpaceRoomList.#6043

Merged
stefanceriu merged 1 commit into
mainfrom
doug/reset-space-list
Jan 20, 2026
Merged

Spaces: Add a method to reset a SpaceRoomList.#6043
stefanceriu merged 1 commit into
mainfrom
doug/reset-space-list

Conversation

@pixlwave
Copy link
Copy Markdown
Member

@pixlwave pixlwave commented Jan 19, 2026

We now have the ability to add/remove space children in #5871, however as the SpaceRoomList is based on /hierarchy it isn't aware of any changes made by the space service. This PR helps by making a way to reset the list so that the next paginate() call starts from the beginning again.

Whilst we could listen for m.space.child/parent events in the sync loop, this wouldn't help if you removed a room where you aren't a member.

@pixlwave pixlwave requested a review from a team as a code owner January 19, 2026 16:03
@pixlwave pixlwave requested review from poljar and removed request for a team January 19, 2026 16:03
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.94%. Comparing base (0053ecb) to head (06744f9).
⚠️ Report is 21 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6043   +/-   ##
=======================================
  Coverage   88.94%   88.94%           
=======================================
  Files         358      358           
  Lines       99283    99312   +29     
  Branches    99283    99312   +29     
=======================================
+ Hits        88308    88337   +29     
+ Misses       6988     6987    -1     
- Partials     3987     3988    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Jan 19, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing doug/reset-space-list (06744f9) with main (0053ecb)

Open in CodSpeed

Copy link
Copy Markdown
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, looks good to me 👍

Comment thread bindings/matrix-sdk-ffi/src/spaces.rs
@stefanceriu stefanceriu merged commit d278f20 into main Jan 20, 2026
53 checks passed
@stefanceriu stefanceriu deleted the doug/reset-space-list branch January 20, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants