Spaces: Add a method to reset a SpaceRoomList.#6043
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6043 +/- ##
=======================================
Coverage 88.94% 88.94%
=======================================
Files 358 358
Lines 99283 99312 +29
Branches 99283 99312 +29
=======================================
+ Hits 88308 88337 +29
+ Misses 6988 6987 -1
- Partials 3987 3988 +1 ☔ View full report in Codecov by Sentry. |
stefanceriu
approved these changes
Jan 20, 2026
Member
stefanceriu
left a comment
There was a problem hiding this comment.
Beautiful, looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have the ability to add/remove space children in #5871, however as the
SpaceRoomListis based on/hierarchyit isn't aware of any changes made by the space service. This PR helps by making a way to reset the list so that the nextpaginate()call starts from the beginning again.Whilst we could listen for
m.space.child/parentevents in the sync loop, this wouldn't help if you removed a room where you aren't a member.