refactor(sdk-ui): remove expect() with better borrow

[BillCarsonFr]

Follow up on review on this PR #6494 (comment)

Remove the usage of if/expect that was introduced because of a borrowing problem.
Instead we use ok_or_else, but we clone the debug_string early (to avoid needing to borrow event again in the ok_or_else), it is not ideal either but better that the expect/panic

I also removed the is_rtc_notification and is_live_location that was created I believe just to avoid the borrowing problem? They were only used in test and it just a shortcut for matches!()

• I've documented the public API Changes in the appropriate CHANGELOG.md files.
• This PR was made with the help of AI.

Signed-off-by:

[codecov]

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.87%. Comparing base (3ac1f06) to head (7273568).
⚠️ Report is 26 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...rix-sdk-ui/src/timeline/controller/aggregations.rs	64.28%	5 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6513   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files         381      381           
  Lines      105781   105758   -23     
  Branches   105781   105758   -23     
=======================================
- Hits        95071    95051   -20     
- Misses       7048     7051    +3     
+ Partials     3662     3656    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Hywan]

See my proposal to avoid allocating the debug_string for nothing if event is a poll.

[Hywan]

Not sure if the following works but it seems ok:

if let TimelineItemContent::MsgLike(MsgLikeContent { kind: MsgLikeKind::Poll(state), ..}) = event.to_mut().content_mut() {
    Ok(state)
} else {
    Err(AggregationError::InvalidType {
        expected: "a poll".to_owned(),
        actual: event.content().debug_string().to_owned(),
    })
}

[BillCarsonFr]

You will have the borrow issue :/ event.to_mut() borrows event mutably for the lifetime 'a so for all the function scope, thus you cannot borrow again in the else

[BillCarsonFr]

I think this is what is described here? https://rust-lang.github.io/rfcs/2094-nll.html#problem-case-3-conditional-control-flow-across-functions

[Hywan]

I've tested the following and it works:

let content = event.to_mut().content_mut();

if let TimelineItemContent::MsgLike(MsgLikeContent { kind: MsgLikeKind::Poll(state), .. }) =
    content
{
    Ok(state)
} else {
    Err(AggregationError::InvalidType {
        expected: "a poll".to_owned(),
        actual: content.debug_string().to_owned(),
    })
}

[codspeed-hq]

Merging this PR will not alter performance

✅ 50 untouched benchmarks

---

_{Comparing valere/follow_up_aggregation_cleaning (7273568) with main (e90dbb3)}

[Hywan]

It looks great, thanks!