Skip to content

Expose HumanQrGrantLoginError::Unknown reason in error message#6514

Merged
poljar merged 1 commit intomatrix-org:mainfrom
hughns:hughns/HumanQrGrantLoginError-unknown-reason
Apr 28, 2026
Merged

Expose HumanQrGrantLoginError::Unknown reason in error message#6514
poljar merged 1 commit intomatrix-org:mainfrom
hughns:hughns/HumanQrGrantLoginError-unknown-reason

Conversation

@hughns
Copy link
Copy Markdown
Member

@hughns hughns commented Apr 28, 2026

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

Signed-off-by: Hugh Nimmo-Smith hughns@element.io

@hughns hughns force-pushed the hughns/HumanQrGrantLoginError-unknown-reason branch from 1bb6f58 to 568a6a9 Compare April 28, 2026 12:54
@hughns hughns marked this pull request as ready for review April 28, 2026 12:54
@hughns hughns requested a review from a team as a code owner April 28, 2026 12:54
@hughns hughns requested review from andybalaam and removed request for a team April 28, 2026 12:54
@poljar poljar enabled auto-merge (rebase) April 28, 2026 12:57
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 28, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing hughns:hughns/HumanQrGrantLoginError-unknown-reason (568a6a9) with main (6777907)

Open in CodSpeed

@poljar poljar merged commit b31e0f0 into matrix-org:main Apr 28, 2026
61 of 68 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.90%. Comparing base (6777907) to head (568a6a9).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6514      +/-   ##
==========================================
- Coverage   89.93%   89.90%   -0.03%     
==========================================
  Files         381      381              
  Lines      105781   105781              
  Branches   105781   105781              
==========================================
- Hits        95132    95101      -31     
- Misses       7007     7029      +22     
- Partials     3642     3651       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants