fix: Filter out threaded events from event focused timeline#6519
Merged
jmartinesp merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6519 +/- ##
==========================================
- Coverage 89.94% 89.91% -0.03%
==========================================
Files 381 381
Lines 105753 105757 +4
Branches 105753 105757 +4
==========================================
- Hits 95115 95088 -27
- Misses 6993 7022 +29
- Partials 3645 3647 +2 ☔ View full report in Codecov by Sentry. |
04d6971 to
0090281
Compare
Contributor
Author
|
Just to mention I also tried to implement this in So it seems like the event cache is the right place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using a focused event timeline with a non-threaded focus event, other threaded events were still included in the timeline, so you could see both the thread roots with their summaries and the threaded events that should be hidden.
This was first reported here .
Changes
Add
hide_thread_eventsproperty toEventFocusedPaginationMode::Roomso we can customise this behaviour in the event cache pagination.In the methods that load new events in
EventFocusedCacheInner, use this new info to exclude the events that are part of a thread.I've documented the public API Changes in the appropriate
CHANGELOG.mdfiles.This PR was made with the help of AI.
Signed-off-by: