Skip to content

Bindings: re-run build scripts if NDK changes location#6538

Merged
richvdh merged 1 commit intomainfrom
rav/handle_ndk_changes
May 5, 2026
Merged

Bindings: re-run build scripts if NDK changes location#6538
richvdh merged 1 commit intomainfrom
rav/handle_ndk_changes

Conversation

@richvdh
Copy link
Copy Markdown
Member

@richvdh richvdh commented May 5, 2026

The build scripts for the FFI bindings embed the path to the Android NDK in the target directory, so if the NDK changes location, we need to re-run the build scripts to avoid a linker error.

The build scripts for the FFI bindings embed the path to the Android NDK in the
target directory, so if the NDK changes location, we need to re-run the build
scripts to avoid a linker error.
@richvdh richvdh requested a review from a team as a code owner May 5, 2026 11:49
@richvdh richvdh requested review from Hywan and removed request for a team May 5, 2026 11:49
Copy link
Copy Markdown
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me, thanks!

@richvdh richvdh enabled auto-merge (squash) May 5, 2026 11:52
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.94%. Comparing base (4e8ceaa) to head (74c5238).
⚠️ Report is 7 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6538      +/-   ##
==========================================
- Coverage   89.94%   89.94%   -0.01%     
==========================================
  Files         381      381              
  Lines      105871   105871              
  Branches   105871   105871              
==========================================
- Hits        95228    95227       -1     
- Misses       6999     7008       +9     
+ Partials     3644     3636       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richvdh richvdh merged commit 2ec031b into main May 5, 2026
53 checks passed
@richvdh richvdh deleted the rav/handle_ndk_changes branch May 5, 2026 12:04
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 5, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing rav/handle_ndk_changes (74c5238) with main (8b13e48)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants