Conditionalize search behind experimental-search feature flag#6539
Merged
poljar merged 1 commit intomatrix-org:mainfrom May 6, 2026
Merged
Conversation
Move search module and SearchIndexStoreKind usage behind #[cfg(feature = "experimental-search")] so builds without the feature don't pull in search dependencies.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6539 +/- ##
=======================================
Coverage 89.92% 89.92%
=======================================
Files 381 381
Lines 105914 105914
Branches 105914 105914
=======================================
+ Hits 95243 95247 +4
+ Misses 7029 7014 -15
- Partials 3642 3653 +11 ☔ View full report in Codecov by Sentry. |
poljar
approved these changes
May 6, 2026
Contributor
poljar
left a comment
There was a problem hiding this comment.
Doh, very true that this can't work on Wasm.
This keeps on happening, I wonder if CI should attempt to build or at least cargo check the bindings for Wasm support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move search module and SearchIndexStoreKind usage behind #[cfg(feature = "experimental-search")] so builds without the feature don't pull in search dependencies. The transitive dependencies of the
experimental-searchfeature in the matrix-sdk crate are currently breaking 'wasm' target builds.CHANGELOG.mdfiles.Signed-off-by: Daniel Salinas