Skip to content

Conditionalize search behind experimental-search feature flag#6539

Merged
poljar merged 1 commit intomatrix-org:mainfrom
filament-dm:conditionalize-experimental-search
May 6, 2026
Merged

Conditionalize search behind experimental-search feature flag#6539
poljar merged 1 commit intomatrix-org:mainfrom
filament-dm:conditionalize-experimental-search

Conversation

@zzorba
Copy link
Copy Markdown
Contributor

@zzorba zzorba commented May 5, 2026

Move search module and SearchIndexStoreKind usage behind #[cfg(feature = "experimental-search")] so builds without the feature don't pull in search dependencies. The transitive dependencies of the experimental-search feature in the matrix-sdk crate are currently breaking 'wasm' target builds.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

Signed-off-by: Daniel Salinas

Move search module and SearchIndexStoreKind usage behind
#[cfg(feature = "experimental-search")] so builds without the
feature don't pull in search dependencies.
@zzorba zzorba requested a review from a team as a code owner May 5, 2026 16:20
@zzorba zzorba requested review from stefanceriu and removed request for a team May 5, 2026 16:20
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.92%. Comparing base (2ec031b) to head (d42bfbe).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6539   +/-   ##
=======================================
  Coverage   89.92%   89.92%           
=======================================
  Files         381      381           
  Lines      105914   105914           
  Branches   105914   105914           
=======================================
+ Hits        95243    95247    +4     
+ Misses       7029     7014   -15     
- Partials     3642     3653   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 5, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing filament-dm:conditionalize-experimental-search (d42bfbe) with main (2ec031b)

Open in CodSpeed

Copy link
Copy Markdown
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, very true that this can't work on Wasm.

This keeps on happening, I wonder if CI should attempt to build or at least cargo check the bindings for Wasm support.

@poljar poljar merged commit 65cdd9d into matrix-org:main May 6, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants