Store SlidingSyncPositionMarkers in EventCacheStore#6541
Open
mgoldenberg wants to merge 15 commits intomatrix-org:mainfrom
Open
Store SlidingSyncPositionMarkers in EventCacheStore#6541mgoldenberg wants to merge 15 commits intomatrix-org:mainfrom
SlidingSyncPositionMarkers in EventCacheStore#6541mgoldenberg wants to merge 15 commits intomatrix-org:mainfrom
Conversation
Initial implementations for SQLite, IndexedDB, and in-memory stores do nothing. Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
…store Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
… store Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6541 +/- ##
=======================================
Coverage 89.92% 89.93%
=======================================
Files 381 381
Lines 105914 105942 +28
Branches 105914 105942 +28
=======================================
+ Hits 95243 95274 +31
+ Misses 7029 7022 -7
- Partials 3642 3646 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
SlidingSyncPositionMarkersare stored in theCryptoStore. This store was chosen, as the position markers needed to be accessible in a way that could be synchronized across processes - i.e., a store protected by a cross-process lock.Originally, the only store to provide this functionality was the
CryptoStore, but this means that when end-to-end encryption is not enabled, there is no way to store the position markers. So, now that theEventCacheStoreis protected by a cross-process lock and is always accessible, it is a more reasonable option.Changes
EventCacheStoretrait for getting, setting, and removing custom valuesCryptoStore, which makes this pull request simpler - but we could use more tailored functions for this behavior, if that is preferable.EventCacheStoreCloses #6401.
CHANGELOG.mdfiles.Signed-off-by: Michael Goldenberg m@mgoldenberg.net