Skip to content

feat(ffi): introduce a mark_all_rooms_as_read method for mitigating backend badge count issues#6550

Merged
stefanceriu merged 1 commit into
mainfrom
stefan/markAllAsRead
May 8, 2026
Merged

feat(ffi): introduce a mark_all_rooms_as_read method for mitigating backend badge count issues#6550
stefanceriu merged 1 commit into
mainfrom
stefan/markAllAsRead

Conversation

@stefanceriu
Copy link
Copy Markdown
Member

The idea is to introduce a developer option within Element X which would invoke this method and mitigate element-hq/element-x-ios#3151, perhaps help make whatever's wrong on the backend more obvious.
This is a stopgap solution until we can deliver proper app/sdk side unread counting and badge updates.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.91%. Comparing base (777ce05) to head (a5bd0d7).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6550      +/-   ##
==========================================
- Coverage   89.92%   89.91%   -0.01%     
==========================================
  Files         381      381              
  Lines      106860   106860              
  Branches   106860   106860              
==========================================
- Hits        96095    96087       -8     
- Misses       7108     7121      +13     
+ Partials     3657     3652       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu force-pushed the stefan/markAllAsRead branch from b3b132f to a5bd0d7 Compare May 8, 2026 05:59
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 8, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing stefan/markAllAsRead (a5bd0d7) with main (777ce05)

Open in CodSpeed

@stefanceriu stefanceriu marked this pull request as ready for review May 8, 2026 08:31
@stefanceriu stefanceriu requested a review from a team as a code owner May 8, 2026 08:31
@stefanceriu stefanceriu requested review from Hywan and removed request for a team May 8, 2026 08:31
Copy link
Copy Markdown
Member

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock the situation, but we must not keep this ^^.

@stefanceriu stefanceriu merged commit 54bd273 into main May 8, 2026
61 checks passed
@stefanceriu stefanceriu deleted the stefan/markAllAsRead branch May 8, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants