fix: can_be_replied_to() returns false for LiveLocation events.#6563
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6563 +/- ##
==========================================
+ Coverage 89.92% 89.95% +0.03%
==========================================
Files 381 381
Lines 107620 107718 +98
Branches 107620 107718 +98
==========================================
+ Hits 96778 96900 +122
+ Misses 7170 7151 -19
+ Partials 3672 3667 -5 ☔ View full report in Codecov by Sentry. |
|
If |
No, because |
|
|
|
I think it is sensible to say that live location messages can't be replied to, and this looks like a reasonable way to do it. Along with tests, I would like the comment to explain itself a little more. Maybe something like "Live location messages are not displayed on the timeline individually, so can't be replied to." |
|
Thanks. I asked AI to add tests. |
andybalaam
left a comment
There was a problem hiding this comment.
I fixed the terrible test names your AI produced.
1899def to
4074ee8
Compare
Let
can_be_replied_to()returnsfalseforLiveLocationevents.I do not really understand why
self.content.is_message()returnfalseforLiveLocationevents, because when I read the code it should returntrue, but it's not the case.If reviewer agrees with the change, I will spend time to add unit test and changelog.
Closes #6562
CHANGELOG.mdfiles.Signed-off-by: