refactor(sdk): Some error refactoring#6574
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6574 +/- ##
=======================================
Coverage 89.92% 89.93%
=======================================
Files 381 381
Lines 107718 107703 -15
Branches 107718 107703 -15
=======================================
- Hits 96870 96865 -5
+ Misses 7173 7164 -9
+ Partials 3675 3674 -1 ☔ View full report in Codecov by Sentry. |
Merging this PR will not alter performance
Comparing Footnotes
|
poljar
reviewed
May 14, 2026
stefanceriu
approved these changes
May 15, 2026
Member
stefanceriu
left a comment
There was a problem hiding this comment.
Looks good to me, thanks Kevin! Please change the.. chagelog and then I'll merge it 🙂
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
By using helper methods on error types. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
They have similar variants containing the same data so it's not useful to have separate types. Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2 first commits are a bit of cleanup. The last one makes
RumaApiErrora type alias ofUiaaResponsebecause they are identical except for variant names so it might be more controversial.CHANGELOG.mdfiles.