Skip to content

refactor(sdk): Some error refactoring#6574

Merged
poljar merged 3 commits into
matrix-org:mainfrom
zecakeh:refactor-error
May 15, 2026
Merged

refactor(sdk): Some error refactoring#6574
poljar merged 3 commits into
matrix-org:mainfrom
zecakeh:refactor-error

Conversation

@zecakeh
Copy link
Copy Markdown
Collaborator

@zecakeh zecakeh commented May 14, 2026

The 2 first commits are a bit of cleanup. The last one makes RumaApiError a type alias of UiaaResponse because they are identical except for variant names so it might be more controversial.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

@zecakeh zecakeh requested a review from a team as a code owner May 14, 2026 08:12
@zecakeh zecakeh requested review from stefanceriu and removed request for a team May 14, 2026 08:12
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.93%. Comparing base (c253114) to head (c737a7f).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/encryption/mod.rs 50.00% 0 Missing and 1 partial ⚠️
...rates/matrix-sdk/src/widget/machine/from_widget.rs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6574   +/-   ##
=======================================
  Coverage   89.92%   89.93%           
=======================================
  Files         381      381           
  Lines      107718   107703   -15     
  Branches   107718   107703   -15     
=======================================
- Hits        96870    96865    -5     
+ Misses       7173     7164    -9     
+ Partials     3675     3674    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing zecakeh:refactor-error (c5ad7b7) with main (2a8d75e)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread crates/matrix-sdk/CHANGELOG.md Outdated
Copy link
Copy Markdown
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Kevin! Please change the.. chagelog and then I'll merge it 🙂

zecakeh added 3 commits May 15, 2026 09:54
Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
By using helper methods on error types.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
They have similar variants containing the same data so it's not useful
to have separate types.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
@stefanceriu stefanceriu enabled auto-merge (rebase) May 15, 2026 08:10
@poljar poljar disabled auto-merge May 15, 2026 10:04
@poljar poljar merged commit edb5d41 into matrix-org:main May 15, 2026
53 of 64 checks passed
@zecakeh zecakeh deleted the refactor-error branch May 15, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants