Skip to content

fix: Refresh timeline items when their sender's avatar URL changes#6576

Merged
poljar merged 1 commit into
mainfrom
fix/refresh-timeline-items-when-sender-changes-avatar-url
May 15, 2026
Merged

fix: Refresh timeline items when their sender's avatar URL changes#6576
poljar merged 1 commit into
mainfrom
fix/refresh-timeline-items-when-sender-changes-avatar-url

Conversation

@jmartinesp
Copy link
Copy Markdown
Contributor

@jmartinesp jmartinesp commented May 14, 2026

This is similar to what happens when a user's display name changes, its ambiguity is calculated and if it changes, it reloads the associated timeline events.

In fact, this change tries to follow the same strategy as AmbiguityCache.

Fixes #6575.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

Signed-off-by:

This is similar to what happens when a user display name changes, its ambiguity is calculated and if it changes, it reloads the associated timeline events.

In fact, this change tries to follow the same strategy as `AmbiguityCache`.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2026

Codecov Report

❌ Patch coverage is 94.39252% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.95%. Comparing base (2a8d75e) to head (97ccd3b).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/store/avatar_cache.rs 94.91% 3 Missing ⚠️
crates/matrix-sdk-ui/src/timeline/tasks.rs 81.81% 2 Missing ⚠️
...x-sdk-base/src/response_processors/state_events.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6576   +/-   ##
=======================================
  Coverage   89.94%   89.95%           
=======================================
  Files         381      382    +1     
  Lines      107718   107812   +94     
  Branches   107718   107812   +94     
=======================================
+ Hits        96889    96980   +91     
- Misses       7160     7161    +1     
- Partials     3669     3671    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing fix/refresh-timeline-items-when-sender-changes-avatar-url (97ccd3b) with main (2a8d75e)

Open in CodSpeed

@jmartinesp jmartinesp marked this pull request as ready for review May 14, 2026 20:41
@jmartinesp jmartinesp requested a review from a team as a code owner May 14, 2026 20:41
@jmartinesp jmartinesp requested review from Hywan and removed request for a team May 14, 2026 20:41
Copy link
Copy Markdown
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

The tests were quite useful to confirm this.

@poljar poljar merged commit 7c13b60 into main May 15, 2026
67 of 68 checks passed
@poljar poljar deleted the fix/refresh-timeline-items-when-sender-changes-avatar-url branch May 15, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Room member display name changes update the timeline sender, but avatar updates don't

2 participants