feat: Add support for MSC4471 event streams#6607
Open
bradtgmurray wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6607 +/- ##
==========================================
- Coverage 89.96% 89.68% -0.28%
==========================================
Files 382 386 +4
Lines 107971 109167 +1196
Branches 107971 109167 +1196
==========================================
+ Hits 97136 97911 +775
- Misses 7167 7574 +407
- Partials 3668 3682 +14 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an initial implementation of a portion of MSC4471. Included in this pull request is the the matrix-sdk changes, validated by unit tests. Not included in this pull request is changes to matrix-sdk-ui, which I figured would be best done as a follow up to keep this original PR a reasonable size. Also, encryption of the stream events is not yet implemented, again to manage the size of this initial PR.
This MSC has not been merged, but I'd like to use matrix-rust-sdk as a testing ground for it.
My experience with Rust is rather light, and I did use AI to assist me in writing this PR, but I did quite a bit of iteration to make something that looks reasonably good to my inexperienced eyes. Feedback is greatly appreciated!
NOTE: This pull request isn't mergable as is as it's dependant on me adding the appropriate types to Ruma. Unfortunately, it looks like Ruma does not permit AI-assissted changes, so my work isn't mergable as is. I would love some advice on how to proceed on that front. For now, this branch has adjusted the dependency to point to my fork of Ruma, but that is obviously not a good idea to merge like that.
Signed-off-by: Brad Murray bradtgmurray@gmail.com