feat(ui): Allow specifying membership states for TimelineEventFilter#6644
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6644 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 382 382
Lines 108002 108012 +10
Branches 108002 108012 +10
=======================================
+ Hits 97154 97166 +12
+ Misses 7177 7176 -1
+ Partials 3671 3670 -1 ☔ View full report in Codecov by Harness. |
e0a0c93 to
46dfbe3
Compare
46dfbe3 to
6b4a1a8
Compare
|
Beautiful! 🤩 |
poljar
left a comment
There was a problem hiding this comment.
This looks good, except for some missing docs though.
Approving ahead of time.
Out of interest, what's the use-case here? EX won't show all member changes, just some? Which ones?
| #[cfg_attr(feature = "uniffi", derive(uniffi::Enum))] | ||
| #[derive(Clone)] | ||
| pub enum MembershipChangeFilter { | ||
| Any, | ||
| Join, | ||
| Leave, | ||
| Invite, | ||
| Ban, | ||
| Knock, | ||
| } | ||
|
|
There was a problem hiding this comment.
Done in a rebase.
For publicly visible and joinable rooms we don't want to display either profile changes or when a user joins or leaves, it seems. |
This allows us to only include/exclude certain mebership changes
6b4a1a8 to
983bdc1
Compare
This allows us to only include/exclude certain mebership changes.
cc @pixlwave .
(see Writing changelog entries).
Signed-off-by: