Skip to content

feat(ui): Allow specifying membership states for TimelineEventFilter#6644

Merged
jmartinesp merged 3 commits into
mainfrom
feat/allow-specifying-certain-memberships-for-timeline-event-filters
Jun 8, 2026
Merged

feat(ui): Allow specifying membership states for TimelineEventFilter#6644
jmartinesp merged 3 commits into
mainfrom
feat/allow-specifying-certain-memberships-for-timeline-event-filters

Conversation

@jmartinesp

@jmartinesp jmartinesp commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This allows us to only include/exclude certain mebership changes.

cc @pixlwave .

  • I've documented the public API changes in the appropriate changelog files
    (see Writing changelog entries).
  • This PR was made with the help of AI.

Signed-off-by:

@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.95%. Comparing base (f1bea72) to head (983bdc1).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-ui/src/timeline/event_filter.rs 75.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6644   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files         382      382           
  Lines      108002   108012   +10     
  Branches   108002   108012   +10     
=======================================
+ Hits        97154    97166   +12     
+ Misses       7177     7176    -1     
+ Partials     3671     3670    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Jun 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing feat/allow-specifying-certain-memberships-for-timeline-event-filters (983bdc1) with main (f1bea72)

Open in CodSpeed

@jmartinesp jmartinesp force-pushed the feat/allow-specifying-certain-memberships-for-timeline-event-filters branch from e0a0c93 to 46dfbe3 Compare June 4, 2026 16:10
@jmartinesp jmartinesp marked this pull request as ready for review June 4, 2026 16:10
@jmartinesp jmartinesp requested a review from a team as a code owner June 4, 2026 16:10
@jmartinesp jmartinesp requested review from poljar and removed request for a team June 4, 2026 16:10
@jmartinesp jmartinesp force-pushed the feat/allow-specifying-certain-memberships-for-timeline-event-filters branch from 46dfbe3 to 6b4a1a8 Compare June 5, 2026 06:56
@pixlwave

pixlwave commented Jun 5, 2026

Copy link
Copy Markdown
Member

Beautiful! 🤩

@poljar poljar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, except for some missing docs though.

Approving ahead of time.

Out of interest, what's the use-case here? EX won't show all member changes, just some? Which ones?

Comment on lines +60 to +70
#[cfg_attr(feature = "uniffi", derive(uniffi::Enum))]
#[derive(Clone)]
pub enum MembershipChangeFilter {
Any,
Join,
Leave,
Invite,
Ban,
Knock,
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs please.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in a rebase.

@jmartinesp

jmartinesp commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Out of interest, what's the use-case here? EX won't show all member changes, just some? Which ones?

For publicly visible and joinable rooms we don't want to display either profile changes or when a user joins or leaves, it seems.

@jmartinesp jmartinesp force-pushed the feat/allow-specifying-certain-memberships-for-timeline-event-filters branch from 6b4a1a8 to 983bdc1 Compare June 8, 2026 14:27
@jmartinesp jmartinesp enabled auto-merge (rebase) June 8, 2026 14:28
@jmartinesp jmartinesp merged commit 99caed0 into main Jun 8, 2026
80 of 82 checks passed
@jmartinesp jmartinesp deleted the feat/allow-specifying-certain-memberships-for-timeline-event-filters branch June 8, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants