MSC4449: Updated /members filtering#4449
Open
timedoutuk wants to merge 2 commits into
Open
Conversation
Signed-off-by: timedout <git@nexy7574.co.uk>
timedoutuk
force-pushed
the
nexy7574/members-filtering
branch
from
7a9f7e4 to
0b8f025
Compare
turt2live
added
proposal
turt2live
reviewed
Apr 12, 2026
Member
There was a problem hiding this comment.
Implementation requirements:
- Client (using)
- Server (offering)
clokep
reviewed
Apr 13, 2026
Comment on lines
+22
to
+23
| As part of this change, they are also made *mutually exclusive*. Specifying both `membership` and | ||
| `not_membership` in the same query is explicitly forbidden, and will return `400 / M_INVALID_PARAM`. |
Member
There was a problem hiding this comment.
Is not_membership even needed anymore?
Contributor
Author
There was a problem hiding this comment.
I think it's a nice shortcut to be able to specify you want all but a certain membership (for example, not ban + leave gives you everyone who is invited, knocking, or joined), otherwise you have to manually specify every membership you do want. I'd also be fine with just dropping it, I just didn't think it was important.
Comment on lines
+27
to
+30
| This change re-uses existing parameter names and may confuse older servers if newer clients try to | ||
| request data with the updated filter behaviour. In order to attempt to reduce this collision, | ||
| clients should check for the unstable feature or relevant spec version (if merged) in `/versions` | ||
| before using the updated behaviour. |
Member
There was a problem hiding this comment.
Is this a reason to rev the endpoint version?
Contributor
Author
There was a problem hiding this comment.
Probably, especially if not_membership gets removed, but I wanted to get some feedback before deciding that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Context in
#matrix-spec:matrix.org