MSC4454: Deprecating Spoiler Fallback In Media Repository#4454
Open
dozro wants to merge 8 commits into
Open
Conversation
…ilered text Signed-off-by: Rye <git@itsrye.dev>
dozro
changed the title
tulir
added
proposal
clokep
reviewed
Apr 22, 2026
tulir
reviewed
Apr 23, 2026
Member
There was a problem hiding this comment.
Implementation requirements:
- Client that sends the new format defined for
body
tulir
reviewed
Apr 23, 2026
Updated guidelines for handling spoilered content in messages.
11 tasks
nushea
pushed a commit
to nushea/Sable-changes
that referenced
this pull request
Apr 23, 2026
…Client#715) ### Description This pull request updates the plain text conversion logic to better handle spoilered text, ensuring that spoiler formatting is replaced with `[Spoiler]` in plain text fallbacks as per [MSC4454](matrix-org/matrix-spec-proposals#4454). **Spoiler handling improvements:** - Spoilered text (delimited by `||`) is now replaced with `[Spoiler]` in the plain text output, matching the MSC4454 specification. #### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Checklist: - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings ### AI disclosure: - [ ] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). No AI involved
| For example, a notification may display `Alice [Spoiler] in the movie.` rather than including the spoilered text itself. | ||
|
|
||
| While this reduces the usefulness of previews, it avoids leaking spoilered content in contexts where it may be displayed without | ||
| explicit user interaction (such as push notifications or lockscreen previews). |
There was a problem hiding this comment.
Clients like gomuks already handle this by replacing the whole message in plaintext contexts, for example:
In my opinon this particular trafeoff isn't worth the potential loss of information.
Author
There was a problem hiding this comment.
didn't know that. thanks for the info.
will adjust the MSC as soon as i come to it :3
Author
There was a problem hiding this comment.
probably to something like [Spoiler](text goes here) so that the plain text is still usable while still containing information about it being a spoiler.
from `[Spoiler]` to `[Spoiler](spoilered text goes here)` to decrease reliance on rich text rendering thanks to [Sugaryyyy (Sugaryy_)](https://github.com/Sugaryyyy) for the idea and bringing up that this is default behaviour in SchildiChat Legacy Signed-off-by: Rye <git@itsrye.dev>
Signed-off-by: Rye <git@itsrye.dev>
Signed-off-by: Rye <git@itsrye.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
Implementations:
Signed-off-by: Rye git@itsrye.dev