Fix logic error in validation of incoming olm-encrypted messages#2394
Open
tusooa wants to merge 2 commits into
Open
Fix logic error in validation of incoming olm-encrypted messages#2394tusooa wants to merge 2 commits into
tusooa wants to merge 2 commits into
Conversation
c98f241 to
184ff23
Compare
Signed-off-by: tusooa <tusooa@kazv.moe>
richvdh
requested changes
Jun 23, 2026
richvdh
left a comment
Member
There was a problem hiding this comment.
Thanks very much for sorting this out; I think your descriptions are accurate.
I've made some suggestions for minor clarifications, if you don't mind.
Signed-off-by: tusooa <tusooa@kazv.moe> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2363
Pull Request Checklist
Preview: https://pr2394--matrix-spec-previews.netlify.app