Clarify that clients must avoid producing ambiguous matrix.to URIs#2396
Open
HarHarLinks wants to merge 3 commits into
Open
Clarify that clients must avoid producing ambiguous matrix.to URIs#2396HarHarLinks wants to merge 3 commits into
HarHarLinks wants to merge 3 commits into
Conversation
anoadragon453
requested changes
Jun 23, 2026
anoadragon453
left a comment
anoadragon453
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing all the lowercase verbiage!
|
|
||
| The components of the matrix.to URI (`<identifier>` and | ||
| `<extra parameter>`) MUST be percent-encoded as per RFC 3986. | ||
| Clients MUST NOT produce incorrectly encoded URIs to avoid ambiguous interpretation. |
Member
There was a problem hiding this comment.
Suggested change
| Clients MUST NOT produce incorrectly encoded URIs to avoid ambiguous interpretation. | |
| Clients MUST NOT produce incorrectly encoded URIs to avoid ambiguous | |
| interpretation. |
|
|
||
| The components of the matrix.to URI (`<identifier>` and | ||
| `<extra parameter>`) MUST be percent-encoded as per RFC 3986. | ||
| Clients MUST NOT produce incorrectly encoded URIs to avoid ambiguous interpretation. |
Member
There was a problem hiding this comment.
What point is this making other than making the previous statement harder to skim over? Assuming that "incorrectly encoded" means "not percent-encoded".
Contributor
Author
There was a problem hiding this comment.
historically, major implementations have ignored this:
Contributor
Author
There was a problem hiding this comment.
"incorrectly encoded" means "not encoded according to spec" 🤷
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec already says this, yet clients tend to ignore what is clearly a requirement here, so this is an attempt to clarify. Note the notice further down about still trying to interpret unencoded (incorrect) URIs at best effort is left intact.
See also matrix-org/matrix.to#404.
Updated the section about matrix.to with RFC 2119 lingo while at it.
Pull Request Checklist
Preview: https://pr2396--matrix-spec-previews.netlify.app