feat: Add support for HPKE#377
Open
poljar wants to merge 15 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 90.93% 91.69% +0.75%
==========================================
Files 34 40 +6
Lines 4955 5501 +546
Branches 4955 5501 +546
==========================================
+ Hits 4506 5044 +538
- Misses 286 287 +1
- Partials 163 170 +7 ☔ View full report in Codecov by Harness. |
poljar
force-pushed
the
poljar/hpke-pr
branch
4 times, most recently
from
July 10, 2026 14:13
587d6aa to
947dfe5
Compare
dkasak
requested changes
Jul 17, 2026
dkasak
left a comment
dkasak
left a comment
Member
There was a problem hiding this comment.
Almost there. I fixed a bunch of things myself (pair reviewing with poljar) and requested a single change. Once that's done, we're good to approve.
| let their_public_key = *encapsulated_key; | ||
| let our_public_key = Curve25519PublicKey::from(&secret_key); | ||
|
|
||
| let secret_key = convert_secret_key(&secret_key); |
Member
There was a problem hiding this comment.
Since the secret key is never exposed, couldn't we use hpke::PrivateKey instead and only do the conversion for the public key?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #289.
Cleans up the history a bit and rebases on top of main now that #206 is merged, otherwise it's the same as #289.
I left the branch for #289 alive as the Rust SDK PR uses the git revisions and I didn't want to break the build as I