Skip to content

Commit e455bdc

Browse files
committed
eliminate legacy replace path and unify to operator-based execution
- Route ODKU all-column-self-update rewrite through modern path - Support fake PK tables (no PK + UK) in modern path - Support vector index tables in modern path (skip irregular indexes) - Remove legacy build_replace.go, scope.replace(), and all related code - Clean up proto: mark ReplaceCtx, Node.REPLACE, Query.REPLACE as reserved - Remove Node_REPLACE references from explain code - Add BVT tests for NULL UK, fake PK+UK, and ODKU scenarios Issue: #23946
1 parent ed34bf3 commit e455bdc

19 files changed

Lines changed: 1474 additions & 2115 deletions

pkg/frontend/mysql_cmd_executor.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2302,12 +2302,6 @@ func checkModify(plan0 *plan.Plan, resolveFn func(string, string, *plan2.Snapsho
23022302
return true, err
23032303
}
23042304
}
2305-
if ctx := p.Query.Nodes[i].ReplaceCtx; ctx != nil {
2306-
flag, err := checkFn(ctx.Ref, ctx.TableDef)
2307-
if err != nil || flag {
2308-
return true, err
2309-
}
2310-
}
23112305
if ctx := p.Query.Nodes[i].DeleteCtx; ctx != nil {
23122306
flag, err := checkFn(ctx.Ref, ctx.TableDef)
23132307
if err != nil || flag {

pkg/frontend/mysql_cmd_executor_test.go

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2445,13 +2445,6 @@ func Test_checkModify(t *testing.T) {
24452445
expected_flag: true,
24462446
expected_err: false,
24472447
},
2448-
{
2449-
node: &plan.Node{
2450-
ReplaceCtx: &plan0.ReplaceCtx{},
2451-
},
2452-
expected_flag: true,
2453-
expected_err: false,
2454-
},
24552448
{
24562449
node: &plan.Node{
24572450
DeleteCtx: &plan0.DeleteCtx{},

0 commit comments

Comments
 (0)