test: expand GoJieba fulltext BVT coverage#25897
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
gouhongshen
left a comment
There was a problem hiding this comment.
Codex automated review
One non-blocking BVT determinism issue found. Tokenizer unit tests pass; broader tests were blocked by missing local C headers.
P2 - Order exact tokenizer results explicitly (test/distributed/cases/fulltext/gojieba_precise.sql:10)
The six select f.pos, f.word queries assert a specific row sequence, including __DocLen last, but have no ORDER BY. SQL does not guarantee table-function result order, so plan or distributed-execution changes can make this BVT flaky without changing tokenization. Add ORDER BY f.pos to each exact-token query.
What changed
Why
These small deterministic contracts were primarily exercised by nightly regression, so regressions could be detected later than necessary. The new BVT cases move fast functional coverage into the MatrixOne repository without duplicating existing JOIN, UNION, ranking, JSON, primary-key update, large-data, or transaction scenarios.
Impact
Test-only change. No production code or transaction cases are modified.
Validation
go test ./pkg/sql/plan -run FullText -count=1git diff --checkCloses #25896