fix temporal part 2#25899
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
相对 main 的修改主要是 MySQL temporal 兼容:
此次合并 main 已完成,生成的 pipeline.pb.go 同时保留了 temporal 的 reject_zero_temporal 字段和 main 的 Iceberg protobuf 定义。 |
相对 main 的修改主要是 MySQL temporal 兼容:
此次合并 main 已完成,生成的 pipeline.pb.go 同时保留了 temporal 的 reject_zero_temporal 字段和 main 的 Iceberg protobuf 定义。 |
aunjgr
left a comment
There was a problem hiding this comment.
Reviewed the latest head independently across the temporal sentinel closure. Binary and text protocol paths distinguish ZeroDate from valid Date(0); zero DATE/DATETIME/TIMESTAMP handling is propagated through arithmetic, formatting, scalar functions, casts/load paths, and process serialization; ISCP normalizes a non-NULL zero timestamp away from its raw-zero active-job sentinel before state admission. I found no remaining merge-blocking correctness or lifecycle issue in the current code. The Ubuntu UT and coverage checks are still failing and must pass before merge.
What type of PR is this?
Which issue(s) this PR fixes:
issue #25228
#25229
#25263
What this PR does / why we need it:
相对 main 的修改主要是 MySQL temporal 兼容:
此次合并 main 已完成,生成的 pipeline.pb.go 同时保留了 temporal 的 reject_zero_temporal 字段和 main 的 Iceberg protobuf 定义。