fix: reconcile auto-increment state for copy and clone by VioletQwQ-0 · Pull Request #26197 · matrixorigin/matrixone

VioletQwQ-0 · 2026-07-27T03:10:57Z

What type of PR is this?

bug
feature
improvement
documentation

What this PR does / why we need it:

This is the next serial prerequisite in the #25883 split. It makes COPY/CLONE allocator reconciliation independently correct before the user-facing ALTER TABLE ... AUTO_INCREMENT=N entry is enabled.

Invariant:

a visible destination allocator is reset to max(requested offset, copied-row maximum, source allocator offset);
fresh CLONE maps allocator state by cloned column name because planner IDs are in a new coordinate space;
ALTER COPY maps retained columns by stable ColId, preserving rename/reorder and preventing a dropped-and-readded same-name column from inheriting old state;
hidden fake-PK allocators remain independent from visible AUTO_INCREMENT requests;
failed/cancelled ALTER COPY statements discard transaction-private resets, and all internal SQL results are closed.

Changes

collect source allocator offsets and visible row maxima at the selected snapshot/account;
translate source catalog indexes to destination identities before execution;
replace fake value insertion with transaction-aware SetOffset;
reconcile temporary ALTER COPY tables after copied rows become visible in the DDL transaction;
validate destination signed/unsigned integer bounds before resetting;
add regression coverage for fresh ID collisions, rename/reorder, drop/add name reuse, hidden allocators, three-way bounds, overflow, cancellation, rollback cleanup, quoted identifiers, and error-result cleanup;
add an issue-linked distributed case that snapshots the real source allocator offset and proves COPY ALTER preserves its reserved range.

Non-goals

no ALTER TABLE ... AUTO_INCREMENT=N SQL entry;
no mixed-version enablement gate;
no change to the epoch attached to allocated writes;
no generic transaction/recovery changes.

Testing

go test ./pkg/incrservice ./pkg/sql/colexec/table_clone ./pkg/sql/compile -count=1
focused -race runs for the new incrservice, table_clone, and compile tests
go test ./pkg/... -run '^$'
dedicated issue_23143_copy_auto_increment distributed regression added; fresh CI execution is pending for the current head
git diff --check
mo-self-review: PASS
exact-head mo-pr-preflight-review: PASS review=PASS validation=PENDING for 6b1bb91fa0c292ab056adab3a8ba34935125e9fc

Diff size

production code: 5 files, +416/-99
tests: 7 files, +689/-4
generated code: none

Dependency

Depends on the merged epoch fence (#26027) and transactional allocator reset (#26085). The next split item will start from main only after this PR merges.

qodo-code-review · 2026-07-27T05:53:22Z

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

VioletQwQ-0 · 2026-07-27T13:36:16Z

Resolved the current merge conflict in 202a547 by normally merging upstream/main at a55820b.

The only content conflict was in pkg/sql/compile/alter_test.go, where this PR added the AUTO_INCREMENT reset-cleanup test and upstream added the IVF INCLUDE-column affected-index test at the same location. The resolution keeps both complete tests unchanged.

Validation passed: affected package tests, focused race tests for both conflict-adjacent paths, git diff checks, index-plugin domain guards, full self-review, and exact-head preflight. The PR remains Ready; fresh CI is running.

Co-authored-by: ULookup <CHBulookup@outlook.com>

VioletQwQ-0 · 2026-07-27T15:08:27Z

The Ubuntu UT failure on 202a5473e was a 60-minute timeout during the heavy-race phase, not a test failure: the raw job log contains no failed package, panic, assertion, or generated ut-report. The previous PR head completed the same UT in about 25 minutes, and recent upstream PRs on the same runner label completed it in about 29–32 minutes. I classified this as runner/infrastructure performance rather than a code defect.

The branch was four commits behind main, so I rebased it onto c6d7a1168. The only conflict was two adjacent independent tests in pkg/sql/compile/alter_test.go; both complete test functions and their assertions were retained.

Validation on new head 6b1bb91fa:

go test ./pkg/incrservice ./pkg/sql/colexec/table_clone ./pkg/sql/compile -count=1
focused -race tests for the ALTER COPY cleanup, upstream IVF INCLUDE behavior, stable-identity reconciliation, and clone allocator bounds
git diff --check upstream/main...HEAD
complete mo-self-review: PASS
exact-head preflight: PASS review=PASS validation=PENDING

Fresh CI is now running on the rebased head.

XuPeng-SH

Deep-reviewed exact head 6b1bb91fa0.

Verified visible allocator reconciliation (max(requested, copied max, source offset)), stable ColId/name mapping, hidden fake-PK isolation, fulltext/partition hidden-index allocator mapping, rollback cleanup, result lifecycle, integer bounds, snapshot/account handling, and DDL-only performance impact. The previously reported fulltext hidden-table gap is fixed on this head.

Local affected-package tests pass, and exact-head CI/BVT/SCA/coverage are green. No blocking production issue found.

mergify · 2026-07-27T16:13:57Z

Queued — the merge queue status continues in this comment ↓.

mergify · 2026-07-28T06:24:18Z

queue

⚠️ Invalid commit message

Details

section not found

mergify · 2026-07-28T06:28:06Z

Merge Queue Status

🛑 Queue command has been cancelled

mergify · 2026-07-28T06:28:25Z

Merge Queue Status

✅ Entered queue — 2026-07-28 06:28 UTC · Rule: main · triggered by a @mergifyio queue command
🟠 Checks running · in-place
🚫 Left the queue — 2026-07-28 08:23 UTC · at c61c432cc5fb0fe94f0acdc4fcbf1e7258fcc053

This pull request spent 1 hour 55 minutes 42 seconds in the queue, with no time running CI.

Waiting for

All conditions

Reason

Pull request #26197 has been dequeued

Pull request from fork cannot be queued. This pull request comes from a fork, and Mergify needs the author's permission to update its branch.

The author needs to enable "Allow edits from maintainers" on this pull request.

Failing checks:

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

Tick the box to put this pull request back in the merge queue (same as @mergifyio queue).

Requeue this pull request

…reconcile

VioletQwQ-0 temporarily deployed to ci July 27, 2026 03:11 — with GitHub Actions Inactive

matrix-meow added the size/XL Denotes a PR that changes [1000, 1999] lines label Jul 27, 2026

mergify Bot added the kind/bug Something isn't working label Jul 27, 2026

This was referenced Jul 27, 2026

feat(plan): support ALTER TABLE AUTO_INCREMENT = value #25883

Closed

ALTER TABLE AUTO_INCREMENT = value not supported #23143

Open

VioletQwQ-0 had a problem deploying to ci July 27, 2026 03:43 — with GitHub Actions Failure

VioletQwQ-0 temporarily deployed to ci July 27, 2026 04:11 — with GitHub Actions Inactive

VioletQwQ-0 temporarily deployed to ci July 27, 2026 04:42 — with GitHub Actions Inactive

VioletQwQ-0 marked this pull request as ready for review July 27, 2026 05:53

VioletQwQ-0 requested review from XuPeng-SH, aunjgr, gouhongshen and heni02 as code owners July 27, 2026 05:53

VioletQwQ-0 temporarily deployed to ci July 27, 2026 05:53 — with GitHub Actions Inactive

VioletQwQ-0 temporarily deployed to ci July 27, 2026 13:36 — with GitHub Actions Inactive

VioletQwQ-0 had a problem deploying to ci July 27, 2026 13:36 — with GitHub Actions Failure

VioletQwQ-0 temporarily deployed to ci July 27, 2026 13:36 — with GitHub Actions Inactive

VioletQwQ-0 temporarily deployed to ci July 27, 2026 14:11 — with GitHub Actions Inactive

heni02 approved these changes Jul 27, 2026

View reviewed changes

VioletQwQ-0 and others added 6 commits July 27, 2026 23:03

fix: reconcile auto-increment state for copy and clone

eefef3f

Co-authored-by: ULookup <CHBulookup@outlook.com>

test: update vector index copy alter offsets

d858e3f

test: cover copy alter allocator preservation

72b4151

fix: reconcile cloned hidden index allocators

dfef447

fix: stabilize copy allocator CI coverage

c87fc9e

test: match auto increment predicate output

6b1bb91

VioletQwQ-0 force-pushed the codex/issue-23143-copy-clone-auto-increment-reconcile branch from 202a547 to 6b1bb91 Compare July 27, 2026 15:08

VioletQwQ-0 temporarily deployed to ci July 27, 2026 15:08 — with GitHub Actions Inactive

XuPeng-SH approved these changes Jul 27, 2026

View reviewed changes

mergify Bot added 2 commits July 28, 2026 08:18

Merge branch 'main' into codex/issue-23143-copy-clone-auto-increment-…

668bbfb

…reconcile

Merge branch 'main' into codex/issue-23143-copy-clone-auto-increment-…

c61c432

…reconcile

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: reconcile auto-increment state for copy and clone - #26197

fix: reconcile auto-increment state for copy and clone#26197
XuPeng-SH merged 8 commits into
matrixorigin:mainfrom
VioletQwQ-0:codex/issue-23143-copy-clone-auto-increment-reconcile

VioletQwQ-0 commented Jul 27, 2026 •

edited

Loading

Uh oh!

qodo-code-review Bot commented Jul 27, 2026

Uh oh!

VioletQwQ-0 commented Jul 27, 2026

Uh oh!

VioletQwQ-0 commented Jul 27, 2026

Uh oh!

XuPeng-SH left a comment

Uh oh!

mergify Bot commented Jul 27, 2026 •

edited

Loading

Uh oh!

mergify Bot commented Jul 28, 2026

Uh oh!

mergify Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

mergify Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

VioletQwQ-0 commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Changes

Non-goals

Testing

Diff size

Dependency

Uh oh!

qodo-code-review Bot commented Jul 27, 2026

Qodo reviews are paused for this user.

Uh oh!

VioletQwQ-0 commented Jul 27, 2026

Uh oh!

VioletQwQ-0 commented Jul 27, 2026

Uh oh!

XuPeng-SH left a comment

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Jul 28, 2026

⚠️ Invalid commit message

Uh oh!

mergify Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

mergify Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

VioletQwQ-0 commented Jul 27, 2026 •

edited

Loading

mergify Bot commented Jul 27, 2026 •

edited

Loading

mergify Bot commented Jul 28, 2026 •

edited

Loading

mergify Bot commented Jul 28, 2026 •

edited

Loading