WIP: Package import of type alias#155
Open
sudo-suhas wants to merge 1 commit into
Open
Conversation
sudo-suhas
changed the title
Comment on lines
+1
to
+5
| package message | ||
|
|
||
| import "github.com/matryer/moq/pkg/moq/testpackages/typealiaspkgimport/internal/message" | ||
|
|
||
| type Message = message.Message |
There was a problem hiding this comment.
You're importing a package with the same name as the current package. I wonder if that matters. Does the issue still manifest if you do e.g.
Suggested change
| package message | |
| import "github.com/matryer/moq/pkg/moq/testpackages/typealiaspkgimport/internal/message" | |
| type Message = message.Message | |
| package message | |
| import internalmessage "github.com/matryer/moq/pkg/moq/testpackages/typealiaspkgimport/internal/message" | |
| type Message = internalmessage.Message |
Collaborator
Author
There was a problem hiding this comment.
I have changed the name of the package where the type alias was present to alias. The same issue is still present.
sudo-suhas
force-pushed
the
type-alias-pkg-import
branch
from
a66f8a5 to
9311dad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP PR to fix the issue reported in #153.