Skip to content

Playing safe with preventDefault (precheck if the event is cancelable) #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amphiluke wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Playing safe with preventDefault (precheck if the event is cancelable) #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions jquery.touchSwipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@
fingerCount = touches.length;
}
//Else this is the desktop, so stop the browser from dragging content
else if (options.preventDefaultEvents !== false) {
else if (options.preventDefaultEvents !== false && jqEvent.cancelable !== false) {
jqEvent.preventDefault(); //call this on jq event so we are cross browser
}

Expand Down Expand Up @@ -1287,8 +1287,9 @@
*/
function validateDefaultEvent(jqEvent, direction) {

//If the option is set, allways allow the event to bubble up (let user handle weirdness)
if (options.preventDefaultEvents === false) {
//If the option is set, always allow the event to bubble up (let user handle weirdness)
//If the event cannot be cancelled, do not try to prevent default action (it tends to throw)
if (options.preventDefaultEvents === false || jqEvent.cancelable === false) {
return;
}

Expand Down
Loading