Make Dockerfile.dev built containers a drop-in for production images.#682
Merged
Conversation
Collaborator
|
Thanks. Is this a braking change for devcontainer users? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the development Docker image (Dockerfile.dev) to behave like the production/release image, making it easier to swap dev and prod containers when testing against real fabrics.
Changes:
- Align runtime configuration with production by using environment variables (not CLI args) for defaults like
STORAGE_PATH. - Run the container as non-root with UID/GID
1000:1000and pre-create/datawith matching ownership. - Change dependency install to
npm ci --ignore-scriptsto avoid lifecycle scripts running before the source tree is copied in.
Without this change, you can't easily swap a dev container for a production (release) container because there are fundamental differences. Allowing it to be a drop-in replacement makes it easier to test on real fabrics. - Use the same (environment variable) mechanism for configuring the default data path for consistent overrides. - Use the same uid (1000) so permissions match. - Add --ignore-scripts to npm ci to prevent build lifecycle scripts from running before source code is copied.
Contributor
Author
Probably. If someone is running a devcontainer and all of the files created by the (old) container are |
Collaborator
|
Ok I will add info in changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change, you can't easily swap a dev container for a production (release) container because there are fundamental differences. Allowing it to be a drop-in replacement makes it easier to test on real fabrics.