Open
Conversation
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 5308ffb |
Contributor
|
@Combs7th can you help take a first pass review on these changes? |
Contributor
Currently supporting: - Azure Quick Start Evaluation - Mattermost (Azure VM)
NARSimoes
force-pushed
the
nasimoes-docs-vm-offers
branch
from
efb4885 to
ee3aa45
Compare
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA ee3aa45 |
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA a706975 |
NARSimoes
force-pushed
the
nasimoes-docs-vm-offers
branch
from
a706975 to
cef6ce9
Compare
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA cef6ce9 |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “CSP Marketplaces” area to the Deployment Guide, introducing Azure Marketplace-based deployment docs (a quick-start evaluation flow and a production-style Azure-Native offer) and wiring the new section into the Deployment Guide navigation.
Changes:
- Adds a new “CSP Marketplaces” section to the Deployment Guide index.
- Introduces a CSP Marketplaces landing page plus two top-level marketplace guides.
- Adds Azure-specific included content for the evaluation VM and Azure-Native (VM-based) offer.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| source/deployment-guide/deployment-guide-index.rst | Adds CSP Marketplaces to the deployment guide navigation. |
| source/deployment-guide/csp-marketplaces/csp-marketplaces-index.rst | New index/landing page for CSP marketplace deployments. |
| source/deployment-guide/csp-marketplaces/quick-start-evaluation.rst | New marketplace quick-start wrapper page (currently Azure-only). |
| source/deployment-guide/csp-marketplaces/mattermost-azure-native-app.rst | New wrapper page for Azure-Native offer content. |
| source/deployment-guide/csp-marketplaces/azure/quick-start-evaluation.rst | New Azure Marketplace evaluation VM instructions (included content). |
| source/deployment-guide/csp-marketplaces/azure/mattermost-azure-native-app.rst | New Azure Marketplace production-style deployment instructions (included content). |
Contributor
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (6)
📝 WalkthroughWalkthroughAdds a new "CSP Marketplaces" section to the deployment guide with wrapper pages and two Azure Marketplace documents: Quick Start Evaluation (VM) and Mattermost - Azure‑Native (VM-based), each providing Azure Marketplace wizard walkthroughs and post-deployment steps. ChangesAzure Marketplace Deployment Documentation
🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@source/deployment-guide/csp-marketplaces/azure/mattermost-azure-native-app.rst`:
- Line 62: Replace the hardcoded external URL in the "Mattermost Version" bullet
(the text containing "the Mattermost release policy
<https://docs.mattermost.com/product-overview/release-policy.html>") with the
repo's internal Sphinx link role (for example use :ref:`...` or :doc:`...`
pointing to the corresponding release policy doc/page). Edit the line containing
"Mattermost Version:" so it uses the internal reference role and the appropriate
target identifier in the docs rather than the full
https://docs.mattermost.com/... URL.
In `@source/deployment-guide/csp-marketplaces/azure/quick-start-evaluation.rst`:
- Line 77: The step reference in the sentence "In a browser, go to your
**HTTPS** URL..." incorrectly points to "Step 3" for where Linux credentials
were configured; update that reference to "Step 2 (Basics)" so the sentence
reads that the Linux username and password (or SSH key) were configured in Step
2; locate the exact sentence in quick-start-evaluation.rst (the paragraph
starting "In a browser, go to your **HTTPS** URL.") and replace "Step 3" with
"Step 2 (Basics)" to correct the documentation.
- Line 52: Update the imprecise scope about DNS-label uniqueness in the sentence
containing "You must set a **DNS prefix** (label) that is **globally unique** in
Azure; it forms part of your URL." — replace the clause that currently reads "it
is important that you do not already have a matching DNS name within your Azure
subscription" with wording that clarifies the DNS label must be unique across
Azure (not just within the subscription), e.g. "it must be globally unique
across Azure (not just within your subscription), otherwise deployment may
fail."
In `@source/deployment-guide/deployment-guide-index.rst`:
- Line 17: The page has a hidden toctree entry "CSP Marketplaces" but the
visible summary bullet list lacks a matching :doc: entry; update the public
bullet list (the page summary section where other :doc: bullets like the
existing CSP or marketplace entries appear) to add a new :doc:`CSP Marketplaces
</deployment-guide/csp-marketplaces/csp-marketplaces-index>` bullet, matching
the surrounding formatting and indentation style so the section is discoverable
in both the hidden toctree and the visible summary list.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9a9202ea-434b-43e1-9e46-130551d552a6
📒 Files selected for processing (6)
source/deployment-guide/csp-marketplaces/azure/mattermost-azure-native-app.rstsource/deployment-guide/csp-marketplaces/azure/quick-start-evaluation.rstsource/deployment-guide/csp-marketplaces/csp-marketplaces-index.rstsource/deployment-guide/csp-marketplaces/mattermost-azure-native-app.rstsource/deployment-guide/csp-marketplaces/quick-start-evaluation.rstsource/deployment-guide/deployment-guide-index.rst
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 08c9674 |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@source/deployment-guide/quick-start-evaluation.rst`:
- Around line 12-13: In the included Azure Marketplace file
csp-marketplaces/azure/quick-start-evaluation.rst the headings currently use
level-2 underlines (`-`) and must be changed to level-3 underlines (`~`) so they
nest correctly under the "Deployment options" section; update every heading
underline in that file (e.g., for "Prerequisites", "What gets deployed", "Step
1: Select a plan and start creation", etc.) by replacing `-` underlines with `~`
underlines so the headings become level 3 and preserve document hierarchy.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 549b9e87-7fd1-4011-9722-e961b858e2fb
📒 Files selected for processing (6)
source/deployment-guide/csp-marketplaces/azure/mattermost-azure-native-app.rstsource/deployment-guide/csp-marketplaces/azure/quick-start-evaluation.rstsource/deployment-guide/csp-marketplaces/csp-marketplaces-index.rstsource/deployment-guide/csp-marketplaces/quick-start-evaluation.rstsource/deployment-guide/deployment-guide-index.rstsource/deployment-guide/quick-start-evaluation.rst
✅ Files skipped from review due to trivial changes (4)
- source/deployment-guide/deployment-guide-index.rst
- source/deployment-guide/csp-marketplaces/azure/quick-start-evaluation.rst
- source/deployment-guide/csp-marketplaces/csp-marketplaces-index.rst
- source/deployment-guide/csp-marketplaces/azure/mattermost-azure-native-app.rst
🚧 Files skipped from review as they are similar to previous changes (1)
- source/deployment-guide/csp-marketplaces/quick-start-evaluation.rst
NARSimoes
force-pushed
the
nasimoes-docs-vm-offers
branch
from
08c9674 to
30a3618
Compare
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA 30a3618 |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@source/deployment-guide/csp-marketplaces/azure/mattermost-azure-native-app.rst`:
- Line 116: The text currently says the Linux username/password (or SSH key)
were configured in "Step 2" but they are actually configured in "Step 3:
Application"; update the sentence in the Mattermost setup paragraph so it
references "Step 3: Application" (or simply "Step 3") instead of "Step 2" to
accurately point readers to where the Linux credentials were created.
- Around line 91-92: The "Public IP address" bullet contains an ambiguous phrase
"globally unique in Azure for that cloud/region scope"; update that sentence to
explicitly state the uniqueness scope (e.g., replace with "globally unique
within Azure public cloud" if the label must be unique across all Azure regions,
or "unique within the selected region" if uniqueness is only regional) and add a
short clarifying note that explains whether a DNS label like `mydns` in one
region will conflict with the same label in another region; change the text in
the "Public IP address" paragraph accordingly to remove the contradiction.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8b10841e-6370-431c-a031-41eadcd75d32
📒 Files selected for processing (6)
source/deployment-guide/csp-marketplaces/azure/mattermost-azure-native-app.rstsource/deployment-guide/csp-marketplaces/azure/quick-start-evaluation.rstsource/deployment-guide/csp-marketplaces/csp-marketplaces-index.rstsource/deployment-guide/csp-marketplaces/quick-start-evaluation.rstsource/deployment-guide/deployment-guide-index.rstsource/deployment-guide/quick-start-evaluation.rst
✅ Files skipped from review due to trivial changes (4)
- source/deployment-guide/csp-marketplaces/quick-start-evaluation.rst
- source/deployment-guide/deployment-guide-index.rst
- source/deployment-guide/csp-marketplaces/azure/quick-start-evaluation.rst
- source/deployment-guide/csp-marketplaces/csp-marketplaces-index.rst
🚧 Files skipped from review as they are similar to previous changes (1)
- source/deployment-guide/quick-start-evaluation.rst
NARSimoes
force-pushed
the
nasimoes-docs-vm-offers
branch
from
30a3618 to
f40c4f2
Compare
Contributor
Author
Contributor
|
Newest code from mattermost has been published to preview environment for Git SHA f40c4f2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently supporting:
Note - the naming / structure might require more discussion and alignment.
Ticket Link
https://mattermost.atlassian.net/browse/SEC-10043