Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes changelog generation automation by updating the GitHub milestones lookup to handle repositories with more than 100 milestones, ensuring the target milestone (e.g., v11.7.0) can be found reliably.
Changes:
- Paginate through all milestone pages until the requested milestone title is found (or no more pages remain).
- Request milestones in descending order to bias results toward newer milestones for faster matches.
- Improve the “available milestones” debug output to show the most recent milestone titles from page 1.
|
Newest code from mattermost has been published to preview environment for Git SHA c5d3b92 |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesGitHub Changelog Script Enhancement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/scripts/generate_changelog.py:
- Around line 91-92: The requests.get calls that assign to resp (the call "resp
= requests.get(url, headers=HEADERS, params=params)" and the similar call later)
must include an explicit timeout to avoid hanging; update both calls to pass
timeout=30 (i.e., requests.get(..., timeout=30, ...)) so network requests fail
fast on unresponsive API endpoints, leaving the rest of the parameters
(headers/params) unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e9dabe30-daa1-4eac-b34a-2b64c72df18f
📒 Files selected for processing (1)
.github/scripts/generate_changelog.py
|
Newest code from mattermost has been published to preview environment for Git SHA e7d7c25 |
Fix an issue where the changelog automation didn't work properly. The milestones API only returns 100 results per page, and mattermost/mattermost has been active since 2015 — it has hundreds of milestones. The script is only fetching the first page (the oldest ones), so v11.7.0 is never seen. The fix is to paginate through all milestone pages, and sort descending so recent milestones come first.
The fix: