Document datetime_config nested property for interactive dialog fields#1502
Document datetime_config nested property for interactive dialog fields#1502
Conversation
Add documentation for the new datetime_config object on interactive dialog date and datetime elements, introduced in Mattermost v11.8. Adds spec for location_timezone and allow_manual_time_entry. Deprecates the top-level min_date, max_date, and time_interval fields in favor of the nested structure, with precedence when both are set, and retains a backward compatibility note. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Newest code from mattermost has been published to preview environment for Git SHA b5ca58e |
|
Newest code from mattermost has been published to preview environment for Git SHA 8baad30 |
…g docs Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Newest code from mattermost has been published to preview environment for Git SHA 094e3f6 |
📝 WalkthroughWalkthroughDocumentation update to the interactive dialogs schema: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@site/content/integrate/plugins/interactive-dialogs/_index.md`:
- Line 440: Update the three field description sentences that join two
independent clauses to include a comma before "but" for correct
compound-sentence punctuation; specifically edit the table cell containing the
`default` description ("Default value in ISO date format... Full ISO datetime
strings are accepted but only the date part is parsed; timezone information is
ignored.") and the two other similar field descriptions referenced around lines
445–446 so each "but" connecting independent clauses becomes ", but". Ensure
only punctuation is changed and wording remains otherwise identical.
- Around line 569-584: Update the "datetime_config object" section header to
read "Minimum Server Version: 11.8" instead of "11.6" so the heading matches the
documented introduction of the nested datetime_config object; locate the heading
text near the "datetime_config object" title and change the version number to
11.8.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8a24dbb3-2ae4-4a30-8022-7b1c8ba940b5
📒 Files selected for processing (1)
site/content/integrate/plugins/interactive-dialogs/_index.md
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Newest code from mattermost has been published to preview environment for Git SHA 3ad3f28 |
|
Newest code from mattermost has been published to preview environment for Git SHA e0d1acf |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
site/content/integrate/plugins/interactive-dialogs/_index.md (1)
569-584: Consider minor wording clarifications for improved readability.The
datetime_configobject section is technically accurate and comprehensive. Two optional refinements for clarity:
Line 581 - The phrase "either enabling turns the feature on" could be slightly clearer: "When both are set, the feature is enabled if either is
true."Line 583 - The note "(new in 11.8)" refers to when the deprecation occurred, which might be clearer as "As of v11.8" or "Since v11.8".
These are minor stylistic suggestions; the current wording is functional and understandable.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@site/content/integrate/plugins/interactive-dialogs/_index.md` around lines 569 - 584, Update the wording in the datetime_config docs: change the sentence about the deprecated field `allow_manual_time_entry` to read "When both are set, the feature is enabled if either is `true`." (referencing `manual_time_entry` and `allow_manual_time_entry`), and replace the parenthetical "(new in 11.8)" with a clearer phrase such as "Since v11.8" or "As of v11.8" in the backward compatibility note for `datetime_config`.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@site/content/integrate/plugins/interactive-dialogs/_index.md`:
- Around line 569-584: Update the wording in the datetime_config docs: change
the sentence about the deprecated field `allow_manual_time_entry` to read "When
both are set, the feature is enabled if either is `true`." (referencing
`manual_time_entry` and `allow_manual_time_entry`), and replace the
parenthetical "(new in 11.8)" with a clearer phrase such as "Since v11.8" or "As
of v11.8" in the backward compatibility note for `datetime_config`.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 55f4e51c-83f4-4153-aeb4-052608dc876e
📒 Files selected for processing (1)
site/content/integrate/plugins/interactive-dialogs/_index.md
|
Newest code from mattermost has been published to preview environment for Git SHA 0ad4749 |
|
Newest code from mattermost has been published to preview environment for Git SHA 64449cf |
|
Newest code from mattermost has been published to preview environment for Git SHA 0167eab |
|
Newest code from mattermost has been published to preview environment for Git SHA d958fea |
Summary
Interactive dialog date and datetime elements now support a nested datetime_config object for grouping date/datetime configuration. This PR documents that structure and deprecates the equivalent top-level fields.
What's documented:
Changes:
Paired with: server + webapp changes in mattermost/mattermost on branch interactive-dialog-property-update.
mattermost/mattermost#36067
Ticket Link
https://mattermost.atlassian.net/browse/MM-68388