Skip to content

Fix OpenAI embedding config using wrong JSON key for model field #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crspeller merged 1 commit into from
Apr 8, 2026
Merged

Fix OpenAI embedding config using wrong JSON key for model field #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion search/embeddings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ type BifrostEmbeddingConfig struct {
type OpenAIEmbeddingConfig struct {
APIKey string `json:"apiKey"`
APIURL string `json:"apiURL,omitempty"`
Model string `json:"defaultModel"` // e.g., "text-embedding-3-small"
Model string `json:"embeddingModel"` // e.g., "text-embedding-3-small"
}

// newEmbeddingProvider creates a new embedding provider based on the provided configuration
Expand Down
21 changes: 21 additions & 0 deletions search/embeddings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,27 @@ func TestVectorStoreConfigUnmarshalEdgeCases(t *testing.T) {
}
}

func TestEmbeddingConfigJSONKeys(t *testing.T) {
t.Run("OpenAIEmbeddingConfig deserializes embeddingModel field", func(t *testing.T) {
raw := json.RawMessage(`{"apiKey": "sk-test", "apiURL": "https://custom.api", "embeddingModel": "text-embedding-3-small"}`)
var cfg OpenAIEmbeddingConfig
require.NoError(t, json.Unmarshal(raw, &cfg))
require.Equal(t, "sk-test", cfg.APIKey)
require.Equal(t, "https://custom.api", cfg.APIURL)
require.Equal(t, "text-embedding-3-small", cfg.Model)
})

t.Run("BifrostEmbeddingConfig deserializes model field", func(t *testing.T) {
raw := json.RawMessage(`{"provider": "openai", "apiKey": "sk-test", "apiURL": "https://custom.api", "model": "text-embedding-3-small"}`)
var cfg BifrostEmbeddingConfig
require.NoError(t, json.Unmarshal(raw, &cfg))
require.Equal(t, "openai", cfg.Provider)
require.Equal(t, "sk-test", cfg.APIKey)
require.Equal(t, "https://custom.api", cfg.APIURL)
require.Equal(t, "text-embedding-3-small", cfg.Model)
})
}

func TestMockProviderDimensions(t *testing.T) {
// Test that the mock provider defaults to 1536 for invalid dimension values

Expand Down
Loading