Remove incorrect certificate warning#149
Open
Jonty wants to merge 2 commits intomattermost:masterfrom
Open
Conversation
javax.net.ssl.SSLHandshakeException can be thrown for a variety of reasons that are not related to the certificate being invalid, most notably socket errors while trying to negotate the TLS session. This can result in spurious warnings about the remote host serving an invalid certificate when a connection is closed, and can easily be triggered by a network change.
Jonty
force-pushed
the
incorrect_ssl_error
branch
from
0399caa to
226d727
Compare
Author
|
Would it be possible for someone to take a look at this? The issue still occurs sporadically and I've heard nothing in response since signing the CLA. |
|
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
javax.net.ssl.SSLHandshakeExceptioncan be thrown for a variety of reasons unrelated to the certificate being invalid - most notably socket errors while trying to negotiate the TLS session. This can result in spurious warnings about the remote host serving an invalid certificate when a connection is closed remotely, and can easily be triggered by a network change.Given the certificate is validated elsewhere we can trust that users will be warned appropriately so removing this unnecessary warning path is the cleanest fix - handling all relevant sub-errors would be very ugly.