ci: add TypeScript and unit test jobs, fix pre-existing CI failures

[pavelzeman]

Summary

Builds on #161 (now merged). Adds the remaining two CI jobs — TypeScript and unit tests — along with fixes for pre-existing issues that prevented them from passing.

Jobs added

• TypeScript — npm run typescript (tsc --noEmit)
• Unit Tests — npm test -- --coverage --passWithNoTests

Fixes

TypeScript errors (40+ failures): All from example/src/ referencing React Native dependencies (@react-navigation/stack, react-native-elements, etc.) that are only installed in example/node_modules, not at the root. Fix: simplify tsconfig.json exclude to just example instead of individual subdirectories.

Unit Tests "No tests found" (exit code 1): This repo has no JS/TS test files — all tests are Kotlin tests in test-runner/. Jest exits with code 1 when it finds zero matching test files. Fix: add --passWithNoTests to the Jest invocation.

Build dependency

build job now gates on all four check jobs: lint, typescript, unit-tests, kotlin-tests.

Notes

• Node.js 22 (aligned with ci: add GitHub Actions workflow (bootstrap for #158) #161)
• Actions pinned to full commit SHAs
• CircleCI config left in place for now

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 295a5c63-8c77-4c9a-a773-d46c3980b13f

📥 Commits

Reviewing files that changed from the base of the PR and between ee0b815 and 88feb18.

📒 Files selected for processing (2)

• .github/workflows/ci.yml
• tsconfig.json

✅ Files skipped from review due to trivial changes (1)

• tsconfig.json

---

📝 Walkthrough

Walkthrough

CI workflow updated: adds typescript and unit-tests jobs, and the build job now depends on lint, typescript, unit-tests, and kotlin-tests. TypeScript config now excludes the top-level example/ directory from compilation.

Changes

Cohort / File(s)	Summary
CI Workflow ​.github/workflows/ci.yml	Added typescript and unit-tests jobs (Node 22, npm caching). build job dependencies extended to require lint, typescript, unit-tests, and kotlin-tests (previously only lint and kotlin-tests).
TypeScript Configuration tsconfig.json	Replaced specific example/... exclusions with a single top-level example entry in exclude, broadening the excluded paths from TypeScript compilation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ci: add GitHub Actions workflow (bootstrap for #158) #161 — Initial CI workflow changes touching the same .github/workflows/ci.yml, related to adding and sequencing CI jobs.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main changes: adding TypeScript and unit test CI jobs while fixing pre-existing failures that prevented them from passing.
Description check	✅ Passed	The description is well-related to the changeset, providing clear context about the CI jobs added, specific fixes for TypeScript and Jest failures, and the rationale for each change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ci/migrate-to-github-actions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

.github/workflows/ci.yml (1)

41-51: Consider uploading coverage artifacts for visibility.

The job generates coverage output but doesn't preserve it. Uploading coverage reports as workflow artifacts (or to a service like Codecov) would provide better visibility into test coverage over time.

♻️ Optional: Upload coverage artifact

       - run: npm ci
       - run: npm test -- --coverage --passWithNoTests
+      - uses: actions/upload-artifact@v4
+        with:
+          name: coverage-report
+          path: coverage/
+          retention-days: 14

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 41 - 51, The unit-tests job currently
runs "npm test -- --coverage --passWithNoTests" but doesn't persist the coverage
output; add an upload step to the "unit-tests" job (after the test step) using
the GitHub Actions upload-artifact action to store coverage files (e.g., upload
"coverage" directory or "coverage/lcov.info") with a clear artifact name such as
"coverage-report"; alternatively, add the Codecov action
(codecov/codecov-action) after the test step to submit coverage to Codecov if
you prefer external reporting.

tsconfig.json (1)

37-39: Redundant exclude entries after adding "example".

Now that "example" is excluded entirely, the more specific patterns "example/detox/**/*" and "example/node_modules" are redundant since TypeScript will already skip the entire example/ directory. Consider removing them for clarity.

♻️ Optional cleanup

   "exclude": [
     "lib",
     "node_modules",
     "build",
     "babel.config.js",
     "metro.config.js",
     "jest.config.js",
-    "example/detox/**/*",
-    "example/node_modules",
     "example"
   ]

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tsconfig.json` around lines 37 - 39, Remove the redundant exclude patterns
"example/detox/**/*" and "example/node_modules" from the tsconfig.json exclude
array since the broader "example" entry already excludes the entire directory;
locate the exclude array containing "example", "example/detox/**/*", and
"example/node_modules" and delete the two specific patterns so only "example"
remains.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 41-51: The unit-tests job currently runs "npm test -- --coverage
--passWithNoTests" but doesn't persist the coverage output; add an upload step
to the "unit-tests" job (after the test step) using the GitHub Actions
upload-artifact action to store coverage files (e.g., upload "coverage"
directory or "coverage/lcov.info") with a clear artifact name such as
"coverage-report"; alternatively, add the Codecov action
(codecov/codecov-action) after the test step to submit coverage to Codecov if
you prefer external reporting.

In `@tsconfig.json`:
- Around line 37-39: Remove the redundant exclude patterns "example/detox/**/*"
and "example/node_modules" from the tsconfig.json exclude array since the
broader "example" entry already excludes the entire directory; locate the
exclude array containing "example", "example/detox/**/*", and
"example/node_modules" and delete the two specific patterns so only "example"
remains.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e0d67fa1-5cbf-407d-a9a6-e7caaddb0986

📥 Commits

Reviewing files that changed from the base of the PR and between 1732edd and ee0b815.

📒 Files selected for processing (2)

• .github/workflows/ci.yml
• tsconfig.json

[esarafianou]

Since there are zero JS/TS test files in this repo, Jest will always exit immediately having done nothing. This burns ~60-90s of CI time on every PR and push to master for a no-op.

I'd recommend adding this job when we introduce JS/TS test files so CI time isn't wasted until then. @pavelzeman did you intentionally include it now so the pipeline is ready when tests are added? That's a valid approach too, it's mainly the CI cost that steers me towards skipping it for now.

[pavelzeman]

Good call @esarafianou — you're right, there are zero JS/TS test files in this repo so the Jest job was a pure no-op burning CI time. Removed it in c4d4515. We can add it back when JS/TS tests are actually introduced.

Also cleaned up the redundant tsconfig.json exclude entries per CodeRabbit's nitpick.

[pavelzeman]

CI Jobs Summary

For clarity on what each job actually does:

• Lint — ESLint static analysis
• TypeScript — tsc --noEmit type-checking (not tests — validates the source compiles cleanly; this caught 40+ real type errors from example/ leaking into the check)
• Kotlin Tests — the only actual test suite in this repo (5 tests: OkHttp interceptor behavior via MockWebServer)
• Build — npm run prepare (compiles the publishable package)

No JS/TS test files exist in this repo, so there's no Jest job. Can be added when JS/TS tests are introduced.