From 88feb182a3d05c2cda45c8ee547a3ad45a4cb078 Mon Sep 17 00:00:00 2001 From: Pavel Zeman Date: Mon, 23 Mar 2026 21:05:47 +0000 Subject: [PATCH 1/2] ci: add TypeScript and unit test jobs, fix pre-existing CI failures MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Builds on #161 (which added the base CI workflow with lint, Kotlin tests, and build). This commit adds the remaining two jobs: - TypeScript — npm run typescript (tsc --noEmit) - Unit Tests — npm test -- --coverage --passWithNoTests Fixes: - TypeScript: exclude example/ from tsconfig.json (references React Navigation deps only in example/node_modules) - Unit Tests: --passWithNoTests since repo has no JS/TS test files (all tests are Kotlin in test-runner/) Build job now depends on all four check jobs. Co-authored-by: Claude --- .github/workflows/ci.yml | 26 +++++++++++++++++++++++++- tsconfig.json | 3 +-- 2 files changed, 26 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 30d39f0cf..cc1d158b6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -26,6 +26,30 @@ jobs: - run: npm ci - run: npm run lint + typescript: + name: TypeScript + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 + - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 + with: + node-version: 22 + cache: npm + - run: npm ci + - run: npm run typescript + + unit-tests: + name: Unit Tests + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 + - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 + with: + node-version: 22 + cache: npm + - run: npm ci + - run: npm test -- --coverage --passWithNoTests + kotlin-tests: name: Kotlin Tests runs-on: ubuntu-latest @@ -43,7 +67,7 @@ jobs: build: name: Build Package runs-on: ubuntu-latest - needs: [lint, kotlin-tests] + needs: [lint, typescript, unit-tests, kotlin-tests] steps: - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 diff --git a/tsconfig.json b/tsconfig.json index 5bb4982a5..4a7b8885d 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -34,7 +34,6 @@ "babel.config.js", "metro.config.js", "jest.config.js", - "example/detox/**/*", - "example/node_modules" + "example" ] } From c4d4515ca3176d597d97ca1d1005abbdde6ae10a Mon Sep 17 00:00:00 2001 From: Pavel Zeman Date: Tue, 24 Mar 2026 15:42:01 +0000 Subject: [PATCH 2/2] ci: remove no-op Jest unit-tests job MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There are zero JS/TS test files in this repo, so the Jest job was burning ~60-90s of CI time per run for nothing. Removed per reviewer feedback — can re-add when JS/TS tests are introduced. Co-authored-by: Claude --- .github/workflows/ci.yml | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cc1d158b6..cdf18bb81 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -38,18 +38,6 @@ jobs: - run: npm ci - run: npm run typescript - unit-tests: - name: Unit Tests - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 - - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4 - with: - node-version: 22 - cache: npm - - run: npm ci - - run: npm test -- --coverage --passWithNoTests - kotlin-tests: name: Kotlin Tests runs-on: ubuntu-latest @@ -67,7 +55,7 @@ jobs: build: name: Build Package runs-on: ubuntu-latest - needs: [lint, typescript, unit-tests, kotlin-tests] + needs: [lint, typescript, kotlin-tests] steps: - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 - uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4