Add constructor for injecting devices in BasicChopperController#231
Open
ketan wants to merge 1 commit into
Open
Add constructor for injecting devices in BasicChopperController#231ketan wants to merge 1 commit into
ketan wants to merge 1 commit into
Conversation
Author
|
I'm open to feedback/change on this. Thanks for all your work on this amazing library. |
This is useful for cases where the pins may be active low, instead of active high.
ketan
force-pushed
the
basic-chopper-controller-improvements
branch
from
71a1253 to
0526aa9
Compare
EAGrahamJr
approved these changes
Feb 18, 2026
EAGrahamJr
left a comment
EAGrahamJr
left a comment
Contributor
There was a problem hiding this comment.
I especially approve of the null-check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for cases where the pins may be active low, instead of active high.