Arrays returned as objects

[StephenTHendrix]

I think I'm just re-reporting #79.

diff({ test: [] }, { test: ['apple'] })
returns
{ test: { 0: 'apple' }

[obrunopolo]

Same for me

[mikila85]

same for me, is there a fix anyone found or should i find a different package?
actually should even be ability to say ignoreArrays:true to just get the new array instead of each index which doesnt really matter to alot of people..

[baermathias]

It seems that this here doesn't work at all:

  diff(
    {
      v: {
        data: [
          {
            blabla: 3,
          },
        ],
      },
    },
    {
      v: {
        data: [
          {},
        ],
      },
    },
  ),

Returns:

[Object: null prototype] {
  v: [Object: null prototype] {
    data: [Object: null prototype] { '0': [Object: null prototype] }
  }
}

[MarlonFauser]

Same issue here!

[meszaros-lajos-gyorgy]

Did anyone find any alternatives to this repo that doesn't have this bug?

[meszaros-lajos-gyorgy]

Here's my current workaround:

import { diff } from 'deep-object-diff'

function isPlainObj(obj: any): boolean {
  return Object.prototype.toString.call(obj) === '[object Object]'
}

function isPositiveInteger(value: string): boolean {
  const n = Number.parseInt(value, 10)
  return Number.isInteger(n) && n >= 0
}

function isArrayLooking(obj: object): boolean {
  return Object.keys(obj).every((key) => {
    return isPositiveInteger(key)
  })
}

function fix(data: any) {
  if (isPlainObj(data)) {
    if (isArrayLooking(data)) {
      data.length = Object.keys(data).length
      data = Array.from(data)
      return data.map((value) => {
        return fix(value)
      })
    } else {
      let kvPairs = Object.entries(data)
      kvPairs = kvPairs.map(([key, value]) => {
        return [key, fix(value)]
      })
      return Object.fromEntries(kvPairs)
    }
  } else {
    return data
  }
}

// -----------

const oldData = ...
const newData = ...

const patch = fix(diff(oldData, newData))