Forward streaming authentication challenges to URLProtocolClient#14
Open
kikeenrique wants to merge 5 commits into
Open
Forward streaming authentication challenges to URLProtocolClient#14kikeenrique wants to merge 5 commits into
kikeenrique wants to merge 5 commits into
Conversation
fix: Bridge URLSession authentication challenge callbacks through PlaybackURLProtocol
so clients can handle trust and credential decisions during streamed live playback requests.
fix: Make the URLProtocolClient test helper explicitly Sendable and use a cross-platform authentication method for synthetic challenges.
test: fix. PlaybackTests touches process-wide URLProtocol registration and shared PlaybackStore state directly. Use playback isolation in addition to serialized execution so these tests cannot race with other suites using .replay(...).
This reverts commit f72eab9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was AI assisted.
This fixes authentication challenge handling for Replay’s live/passthrough streaming path.
When PlaybackURLProtocol falls through to the network, it creates an internal URLSession with StreamingDelegate so responses can be streamed incrementally. That delegate previously did not forward URLSessionTask authentication challenges back to the original URLProtocolClient, so callers had no chance to handle credentials, cancellation, trust decisions, or custom auth behavior during streamed requests.
The PR fixes this by: