Skip to content

Fix #342 polyline disappear when yAxis inverted#347

Merged
mauriciopoppe merged 2 commits into
mauriciopoppe:masterfrom
Linho1219:fix-inverted-polyline
May 24, 2025
Merged

Fix #342 polyline disappear when yAxis inverted#347
mauriciopoppe merged 2 commits into
mauriciopoppe:masterfrom
Linho1219:fix-inverted-polyline

Conversation

@Linho1219
Copy link
Copy Markdown
Contributor

@Linho1219 Linho1219 commented May 21, 2025

Fix #342

@mauriciopoppe
Copy link
Copy Markdown
Owner

/rebase

1 similar comment
@mauriciopoppe
Copy link
Copy Markdown
Owner

/rebase

@mauriciopoppe
Copy link
Copy Markdown
Owner

Please rebase your branch, there's a fix I pushed for the failing job.

@Linho1219 Linho1219 force-pushed the fix-inverted-polyline branch from 3d9b7a9 to 6462f25 Compare May 24, 2025 02:23
@Linho1219
Copy link
Copy Markdown
Contributor Author

Rebased onto master. Thanks for the fix!

@Linho1219
Copy link
Copy Markdown
Contributor Author

Oops, still fail

@Linho1219
Copy link
Copy Markdown
Contributor Author

Linho1219 commented May 24, 2025

I changed async timeout from 100ms to 3000ms and the test passed locally. Try running action again.

@Linho1219
Copy link
Copy Markdown
Contributor Author

I changed async timeout from 100ms to 3000ms and the test passed locally. Try running action again.

Successfully passed here in my fork. See https://github.com/Linho1219/function-plot/actions/runs/15224872411/job/42825597312

@mauriciopoppe mauriciopoppe merged commit 7596fe1 into mauriciopoppe:master May 24, 2025
4 checks passed
@mauriciopoppe
Copy link
Copy Markdown
Owner

Thank you for the bug fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to draw polyline when yAxis is inverted

2 participants