Fix animation glitch on iOS 17#12
Open
borsosbe wants to merge 5 commits into
Open
Conversation
borsosbe
commented
Aug 18, 2024
- Remove combine
- For iOS 17 or later use the new animation callback
- Below that use Task with a delay based on Liquid period
- Tested on physical devices running iOS 16, 17
remove combine trigger from LiquidPathView
bohdansasko
approved these changes
Sep 15, 2024
|
I encountered the same animation glitch with the repo's README's example Liquid code and pointed my I tested the fix on this PR on the following devices:
It worked for all three. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.