Skip to content

Fix animation glitch on iOS 17#12

Open
borsosbe wants to merge 5 commits into
maustinstar:masterfrom
borsosbe:master
Open

Fix animation glitch on iOS 17#12
borsosbe wants to merge 5 commits into
maustinstar:masterfrom
borsosbe:master

Conversation

@borsosbe
Copy link
Copy Markdown

  • Remove combine
  • For iOS 17 or later use the new animation callback
  • Below that use Task with a delay based on Liquid period
  • Tested on physical devices running iOS 16, 17

@mplawley
Copy link
Copy Markdown

I encountered the same animation glitch with the repo's README's example Liquid code and pointed my Liquid package dependency to commit dbd0a02b00de9a4d0171cf63b4998991d13b8502.

I tested the fix on this PR on the following devices:

  • iPhone 15 simulator running iOS 16.1.
  • iPhone 15 simulator running iOS 17.2.
  • iPhone 16 Pro (real device) running iOS 18.0.1

It worked for all three.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants