Skip to content

Commit ae347fb

Browse files
authored
Missing pragma no cover in tests and remove unnecessary if in print config (#924)
1 parent d91aa43 commit ae347fb

2 files changed

Lines changed: 11 additions & 12 deletions

File tree

jsonargparse/_actions.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -183,17 +183,16 @@ def __call__(self, parser, namespace, value, option_string=None):
183183
valid_flags = {"": None, "skip_default": "skip_default", "skip_unset": "skip_unset"} | deprecated_valid_flags
184184
if ruamel_support:
185185
valid_flags["comments"] = "with_comments"
186-
if value is not None:
187-
flags = value[0].split(",")
188-
invalid_flags = [f for f in flags if f not in valid_flags]
189-
if len(invalid_flags) > 0:
190-
raise argument_error(f'Invalid option "{invalid_flags[0]}" for {option_string}')
191-
for flag in [f for f in flags if f != ""]:
192-
mapped = valid_flags[flag]
193-
if deprecated_skip_null(flag):
194-
kwargs["skip_unset"] = True
195-
else:
196-
kwargs[mapped] = True
186+
flags = value[0].split(",")
187+
invalid_flags = [f for f in flags if f not in valid_flags]
188+
if len(invalid_flags) > 0:
189+
raise argument_error(f'Invalid option "{invalid_flags[0]}" for {option_string}')
190+
for flag in [f for f in flags if f != ""]:
191+
mapped = valid_flags[flag]
192+
if deprecated_skip_null(flag):
193+
kwargs["skip_unset"] = True
194+
else:
195+
kwargs[mapped] = True
197196
while hasattr(parser, "parent_parser"):
198197
kwargs["key"] = parser.subcommand if kwargs["key"] is None else parser.subcommand + "." + kwargs["key"]
199198
parser = parser.parent_parser

jsonargparse_tests/test_postponed_annotations.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -285,7 +285,7 @@ def function_nested_partial_forward_ref(
285285
p1: List[List["DefinedClass"]],
286286
p2: "Undefined", # type: ignore[name-defined] # noqa: F821
287287
):
288-
pass
288+
pass # pragma: no cover
289289

290290

291291
def test_nested_partial_forward_ref(parser):

0 commit comments

Comments
 (0)